Skip to content

feat(mediapackagev2): add region attribute on mediapackagev2 resources and extra naming validation#37526

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
jamiepmullan:feat/add-region-attributes-to-mediapackagev2
Apr 10, 2026
Merged

feat(mediapackagev2): add region attribute on mediapackagev2 resources and extra naming validation#37526
mergify[bot] merged 5 commits intoaws:mainfrom
jamiepmullan:feat/add-region-attributes-to-mediapackagev2

Conversation

@jamiepmullan
Copy link
Copy Markdown
Contributor

@jamiepmullan jamiepmullan commented Apr 6, 2026

Reason for this change

Allow cross-region references on an imported MediaPackageV2 channel and extra runtime validation on manifest naming.
Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-medialive-channel-mediapackageoutputdestinationsettings.html
(MediaPackageRegionName)

Description of changes

Overview of change:

  1. Add region attribute on mediapackagev2 resources
  2. add "from***Arn()" functions for imports
  3. Added validation to unique manifest names

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added new unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

add "from***Arn()" functions for imports
Added validation to unique manifest names
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Apr 6, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team April 6, 2026 09:27
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@jamiepmullan jamiepmullan marked this pull request as draft April 6, 2026 09:29
@jamiepmullan jamiepmullan changed the title feat[mediapackagev2]: Add region attribute on mediapackagev2 resources and extra naming validation feat[mediapackagev2]: add region attribute on mediapackagev2 resources and extra naming validation Apr 6, 2026
@jamiepmullan jamiepmullan changed the title feat[mediapackagev2]: add region attribute on mediapackagev2 resources and extra naming validation feat(mediapackagev2): add region attribute on mediapackagev2 resources and extra naming validation Apr 6, 2026
@jamiepmullan jamiepmullan marked this pull request as ready for review April 7, 2026 10:38
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 7, 2026 10:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results48 ran48 passed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates48 ran48 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 7, 2026
@alvazjor alvazjor self-assigned this Apr 9, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 10, 2026
added new Token validation tests
@mergify mergify bot dismissed alvazjor’s stale review April 10, 2026 12:21

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2026

Merge Queue Status

  • Entered queue2026-04-10 13:04 UTC · Rule: default-squash
  • 🚫 Left the queue2026-04-10 13:04 UTC · at 2cb886d2800c0142be8f2614e04259a5aa06fd71

This pull request spent 5 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/spec-update.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify bot dismissed alvazjor’s stale review April 10, 2026 15:29

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2026

Merge Queue Status

  • Entered queue2026-04-10 17:02 UTC · Rule: default-squash
  • Checks skipped · PR is already up-to-date
  • Merged2026-04-10 17:03 UTC · at 47240e13d86eb8c61651556096ea9ca1a6d52a9d

This pull request spent 13 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify mergify bot merged commit 112ed67 into aws:main Apr 10, 2026
29 of 31 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants