fix github release script missing version bump#921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
n/a
What does this PR do / Why do we need it:
CURRENT_CONTROLLER_VERSIONin setup.sh doesn't have thevversion prefix. Currently the script only replaces versions like "v2.0.2", not "2.0.2". This change fixes the release script to correctly replace the version numberIf an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
tested the release script
Automation added to e2e:
n/a
Will this PR introduce any new dependencies?:
no
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
n/a
Does this PR introduce any user-facing change?:
no
Do all end-to-end tests successfully pass when running
make e2e-test?:n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.