Adding fix for incorrect log level bug for versions 2.10.1 & 2.10.3#253
Merged
Adding fix for incorrect log level bug for versions 2.10.1 & 2.10.3#253
Conversation
anrajago
approved these changes
May 7, 2025
anrajago
approved these changes
May 7, 2025
RishabhBajaj97
approved these changes
May 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When using airflow versions 2.9.2 and above customer are unable to see error logs when they set their loglevel to
WARNINGor above. The root cause is that in subprocess.py, the lineself.process_logger.info(line.decode("utf-8"))overrides the log level coming from airflow stream to INFO in subprocess.py.Description of changes:
DEBUGto emit all logs and setting root logger to customer's log level to respect customer's log level.entrypoint.pyto resolve circular dependency issue and breaking down its logic into different files so all files have single responsibility such as:user_requirements.py: Installing user requirements.execute_command.py: Logic for executing all the subprocessessetup_environment.py: Running the startup script and setting up environment variablesTesting
This PR is for V 2.10.1 and 2.10.3. Fix for v2.9.2 has already reached prod.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.