-
Notifications
You must be signed in to change notification settings - Fork 47
[amazon-cloudwatch-observability] feat: bundle ServiceMonitor/PodMonitor CRDs (zero-step install) #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wenegiemepraise
wants to merge
20
commits into
aws-observability:main
Choose a base branch
from
wenegiemepraise:helm-crd-bundling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[amazon-cloudwatch-observability] feat: bundle ServiceMonitor/PodMonitor CRDs (zero-step install) #331
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3e61e2e
feat(otel-container-insights): add ServiceMonitor/PodMonitor v2 OTLP …
wenegiemepraise b721ec3
feat(observability): support per-node Target Allocator allocation str…
wenegiemepraise 0222e9f
Merge remote-tracking branch 'origin/main' into otel-ci-smpm-scrape-path
wenegiemepraise a51dc39
Merge branch 'otel-ci-smpm-scrape-path' into helm-per-node-allocation
wenegiemepraise 072635b
feat(observability): bundle ServiceMonitor/PodMonitor CRDs for zero-s…
wenegiemepraise 48e8330
docs(otel-ci): correct $$$1 escaping comment
wenegiemepraise 32b6ae5
feat(observability): grant TA CRD watch RBAC under scraping gate
wenegiemepraise ee2df6e
fix(observability): restore unhyphenated operator feature-gate IDs
wenegiemepraise cd3fb5e
fix(observability): gate prometheuscr scope processor on SM/PM enable…
wenegiemepraise 7911c6c
fix(observability): render TA ClusterRole/Binding once, not per agent
wenegiemepraise 8bf3d4e
fix(observability): bump bundled SM/PM CRDs to prometheus-operator v0…
wenegiemepraise dee02ff
fix(observability): match release-namespace when adopting bundled CRDs
wenegiemepraise e753a60
test(observability): add shebang and anchor CRD matrix grep patterns
wenegiemepraise 7dd2d8d
fix(observability): fail on invalid prometheusCRDs.install value
wenegiemepraise 1a46b3f
Merge otel-ci-smpm-scrape-path (#329) into helm-crd-bundling
wenegiemepraise 7bfede6
fix(observability): scope per-node allocationStrategy to the otelCI path
wenegiemepraise d57f318
docs(observability): clarify target_node is user-supplied, not chart …
wenegiemepraise d8a49d3
fix(observability): stop stamping node on the SM/PM scraping path
wenegiemepraise c626240
Merge otel-ci-smpm-scrape-path (#329) into helm-per-node-allocation
wenegiemepraise 028a408
Merge helm-per-node-allocation (#330) into helm-crd-bundling
wenegiemepraise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prometheusCRDsEnabledonly matchesalwaysandneverexactly, so anything else falls through and bundles the CRDs, meaning a typo likenevrsilently bundles when otelCI is on. Could we add afailbranch for anything that isn'tauto,always, ornever, like the sibling key already does?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split auto into its own branch and added a catch-all else that fails with prometheusCRDs.install must be one of "auto", "always", or "never", got: , matching the metricResolution sibling.