Conversation
IndexedFiles must be reindexed for this work to have an effect. Without reindexing all thumbnails will display as the missing content icon. Improvements needed: - Populate with icon data instead of `asset_path` when item is missing thumbnail - Move thumbnail logic out of termfreq method and into its own method - This work probably needs an explicit fallback for when a video is missing a thumbnail or `content_ss` is otherwise unable to be pulled from solr. Investigation needed: - Does this affect overall search load times? Need to test with larger datasets.
1 task
cjcolvar
reviewed
Sep 16, 2024
Member
cjcolvar
left a comment
There was a problem hiding this comment.
This is great work, but I'm unsure if it is the best solution given the need to reindex and I'm wondering if data-uris might end up being more of a problem than an improvement. I'd like to leave this PR in draft and talk over how it compares to alternative solutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexedFiles must be reindexed for this work to have an effect. Without reindexing all thumbnails will display as the missing content icon.
Improvements needed:
asset_pathwhen item is missing thumbnailsolr_parameters[:q]is missing.content_ssis otherwise unable to be pulled from solr.Investigation needed: