Repository navigation
fix(bootstrap): apply WebRTC and WebSocket CLI overrides - #966
Open
clippytool wants to merge 1 commit into
Open
clippytool wants to merge 1 commit into
clippytool wants to merge 1 commit into
Conversation
Signed-off-by: clippytool <vetclippy@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bootstrap CLI accepts
--webrtc-portand--ws-transport-enable, but neither option reaches the runtime P2P configuration.Apply an explicitly supplied WebRTC port and enable WebSocket transport when requested, matching the light client's override behavior. Preserve configuration values when the options are omitted, including an already enabled WebSocket transport.
Add four regression tests covering both overrides, preservation of existing values, and WebSocket listener selection.
This fixes configuration propagation; it does not add a native WebRTC listener.
Testing
cargo test --locked -p avail-light-bootstrap --no-default-features config::tests cargo fmt --all -- --check git diff --checkAll checks passed: four configuration tests passed, and formatting and whitespace checks passed. Temporarily removing the two overrides caused both override tests to fail while the two preservation tests still passed; restoring the fix made all four pass again.
Issue
#965