Repository navigation
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ArduPilot/ardupilot#34971
Summary
A alternate approach to ArduPilot#34351, by making the glide failsafe a dedicated mode all the tricky entry and exit behavior is resolved.
Classification & Testing (check all that apply and add your own)
Description
Changes to a dedicated mode, there is some behavior changes as a result, but I think for the better. The benefit of the dedicated mode is that its clearer to the user when they are in normal FBWA and when there in a Glide failsafe. There is no contradiction of reported mode and behavior. I'm open to better name ideas, I wanted to make it clear that this was a failsafe and not related to soaring/thermaling.
This also opens the path for potential improvements, such as gliding into the wind rather than just holding 0/0.