Skip to content

fix: let CLI options take precedence over user settings #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visciang merged 1 commit into from
Jun 6, 2026
Merged

fix: let CLI options take precedence over user settings #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pix/command/graph.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defmodule Pix.Command.Graph do
@spec cmd(Pix.UserSettings.t(), Pix.Config.t(), OptionParser.argv()) :: :ok
def cmd(user_settings, config, argv) do
{cli_opts, args} = Pix.Helper.option_parser_parse!(argv, strict: @cli_args)
cli_opts = Keyword.merge(cli_opts, user_settings.command.graph.cli_opts)
cli_opts = Keyword.merge(user_settings.command.graph.cli_opts, cli_opts)
config_pipelines = config.pipelines

case args do
Expand Down
2 changes: 1 addition & 1 deletion lib/pix/command/ls.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defmodule Pix.Command.Ls do
@spec cmd(Pix.UserSettings.t(), Pix.Config.t(), OptionParser.argv()) :: :ok
def cmd(user_settings, config, argv) do
{cli_opts, args} = Pix.Helper.option_parser_parse!(argv, strict: @cli_args)
cli_opts = Keyword.merge(cli_opts, user_settings.command.ls.cli_opts)
cli_opts = Keyword.merge(user_settings.command.ls.cli_opts, cli_opts)
verbose? = Keyword.get(cli_opts, :verbose, false)
hidden? = Keyword.get(cli_opts, :hidden, false)
config_pipelines = config.pipelines
Expand Down
2 changes: 1 addition & 1 deletion lib/pix/command/run.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ defmodule Pix.Command.Run do
@spec cmd(Pix.UserSettings.t(), Pix.Config.t(), OptionParser.argv()) :: :ok
def cmd(user_settings, config, argv) do
{cli_opts, args} = Pix.Helper.option_parser_parse!(argv, strict: @cli_args)
cli_opts = Keyword.merge(cli_opts, user_settings.command.run.cli_opts)
cli_opts = Keyword.merge(user_settings.command.run.cli_opts, cli_opts)
config_pipelines = config.pipelines

validate_run_cli_opts!(cli_opts)
Expand Down
2 changes: 1 addition & 1 deletion lib/pix/command/shell.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ defmodule Pix.Command.Shell do
@spec cmd(Pix.UserSettings.t(), Pix.Config.t(), OptionParser.argv()) :: :ok
def cmd(user_settings, config, argv) do
{cli_opts, args} = Pix.Helper.option_parser_parse!(argv, strict: @cli_args)
cli_opts = Keyword.merge(cli_opts, user_settings.command.shell.cli_opts)
cli_opts = Keyword.merge(user_settings.command.shell.cli_opts, cli_opts)
config_pipelines = config.pipelines

case args do
Expand Down
2 changes: 1 addition & 1 deletion lib/pix/command/upgrade.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ defmodule Pix.Command.Upgrade do
def cmd(user_settings, argv) do
{cli_opts, _args} = Pix.Helper.option_parser_parse!(argv, strict: @cli_args)

cli_opts = Keyword.merge(cli_opts, user_settings.command.upgrade.cli_opts)
cli_opts = Keyword.merge(user_settings.command.upgrade.cli_opts, cli_opts)
dry_run? = Keyword.get(cli_opts, :dry_run, false)

current_version = Application.fetch_env!(:pix, :version)
Expand Down
Loading