-
Notifications
You must be signed in to change notification settings - Fork 37
feat(contracts): regenerate bundle with hook-event-request #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshuajbouw
wants to merge
2
commits into
main
Choose a base branch
from
feat/sync-hook-event-request
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule contracts
updated
from 467240 to d8f4f3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TypeScript contracts file
packages/astrid-sdk/src/contracts.tsis checked into the repository but has not been regenerated to include the newhook-event-requesttypes. Please run the generation script (e.g.,node packages/astrid-sdk/scripts/generate-contracts.mjs) and commit the updatedcontracts.tsfile to ensure the TS SDK remains in sync with the WIT contracts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The WIT carried the new
hook-event-requestrecord butsrc/contracts.tswas never regenerated on this branch (the prior commit only bumped the WIT and the contracts submodule, not the generated TS). Regenerated via the package prebuild step (node scripts/generate-contracts.mjs) and committed — the diff is purely additive, adding theHookEventRequestinterface (type count 99 → 100), andtsc -bis clean. The generator is deterministic (walks the WIT AST in source order, no sorting/timestamps/randomness), so the same WIT always yields identical output.