fix(kernel): enumerate run-loop capsule tools via the describe fan-out (#1198) - #1382
Merged
joshuajbouw merged 1 commit intoAug 13, 2026
Conversation
jvsteiner
marked this pull request as ready for review
July 26, 2026 12:27
Contributor
Author
|
@joshuajbouw ready for review — pool-less run-loop capsules now leave tools absent so the describe fan-out fires and their tools enumerate (#1198). |
Member
|
Review outcome: useful fix, but not mergeable as posted. The public Rust API compatibility job fails because |
Co-authored-by: Jamie Steiner <jvsteiner@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Joshua J. Bouw <jjb@unicity-labs.com>
joshuajbouw
force-pushed
the
fix/1198-run-loop-tool-enumeration
branch
from
August 13, 2026 14:46
ce7a0ef to
8e83737
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1198.
Summary
A run-loop capsule's tools could remain invisible. Load-time interceptor discovery is unavailable for pool-less run-loop capsules, but persisted or injected
tools: []metadata suppressed the existing describe fan-out that should query the capsule's live responder.Changes
describe_loaded_capsulesignature.toolsabsent when the interceptor path is unavailable sotool.v1.request.describefan-out runs.toolsas live-owned metadata and remove legacy or stale tool surfaces before each probe while preserving unrelated opaque metadata.Verification
cargo fmt --all -- --checkcargo test -p astrid-kernel --lib -- --quiet: 304 passedcargo clippy -p astrid-capsule -p astrid-kernel --all-features -- -D warningsgit diff --cached --checkAI / Tool Assistance
Assisted-by: Anthropic Claude: Opus 4.8
Assisted-by: OpenAI Codex: GPT-5
Claude assisted Jamie with the original implementation. Codex independently reviewed the live discovery and persisted-metadata behavior, fixed the stale metadata suppression path, added regressions, reconciled the patch onto current
main, and validated the affected crates. I reviewed the final combined patch and created the GPG-signed, DCO-compliant commit. Jamie and Claude remain credited as co-authors.Checklist
Signed-off-bytrailer.