Skip to content

docs: fix PLR0124 description to acknowledge __eq__ can be overridden #24717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avasis-ai wants to merge 1 commit into from
Closed

docs: fix PLR0124 description to acknowledge __eq__ can be overridden #24717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/ruff_linter/src/rules/pylint/rules/comparison_with_itself.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ use crate::fix::snippet::SourceCodeSnippet;
/// Checks for operations that compare a name to itself.
///
/// ## Why is this bad?
/// Comparing a name to itself always results in the same value, and is likely
/// a mistake.
/// Comparing a name to itself is likely a mistake, as `__eq__` may be
/// overridden to return a non-trivial value.
Comment on lines +15 to +16
Copy link
Copy Markdown
Contributor

@ntBre ntBre Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is quite the change we were picturing. This phrasing suggests that __eq__ returning an unusual value causes the issue, but the opposite is true. The lint rule applies except when you've overriden __eq__ to return something weird.

///
/// ## Example
/// ```python
Expand Down