[ty] Widen nested literals during inference for huge collections#24716
Closed
charliermarsh wants to merge 5 commits intomainfrom
Closed
[ty] Widen nested literals during inference for huge collections#24716charliermarsh wants to merge 5 commits intomainfrom
charliermarsh wants to merge 5 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.34%. The percentage of expected errors that received a diagnostic held steady at 85.30%. The number of fully passing files held steady at 87/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
|
|
Merging this PR will improve performance by ×5.6
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | ty_micro[typevar_mapping_accumulation] |
370.7 ms | 66.1 ms | ×5.6 |
| ⚡ | Memory | ty_micro[typevar_mapping_accumulation] |
32.6 MB | 13.5 MB | ×2.4 |
Comparing charlie/promote-perf (acd41cb) with main (e002c44)
Footnotes
-
60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
charliermarsh
force-pushed
the
charlie/promote-perf
branch
3 times, most recently
from
ee4b6e2 to
80d61d1
Compare
charliermarsh
force-pushed
the
charlie/promote-perf
branch
from
80d61d1 to
5c219df
Compare
charliermarsh
force-pushed
the
charlie/promote-perf
branch
from
a6bf0fb to
acd41cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovered as part of: astral-sh/ty#1393.