Fix Minimal versions CI by lifting tempfile and is-terminal floors#55
Open
RyanJamesStewart wants to merge 1 commit into
Open
Fix Minimal versions CI by lifting tempfile and is-terminal floors#55RyanJamesStewart wants to merge 1 commit into
Minimal versions CI by lifting tempfile and is-terminal floors#55RyanJamesStewart wants to merge 1 commit into
Conversation
…ns` doesn't pull `rustix = "0.37"` The `Minimal versions` CI job resolves the workspace to its earliest compatible versions on nightly, which pulls `rustix 0.37.0` via two transitive paths: - `proptest 1.6.0 -> tempfile 3.0 -> rustix 0.37` - `codspeed-criterion-compat 4.0.1 -> is-terminal 0.4.6 -> rustix 0.37` rustix 0.37.x uses `rustc_layout_scalar_valid_range_start`, which was removed from the compiler in rust-lang/rust#155433 (merged 2026-05-03). Tracking issue at bytecodealliance/rustix#1620; the 0.37 line is in deep maintenance (0.37.28 released 2025-01-07) and no backport is in flight. Add two direct dev-dep floors, the minimum each path needs to land on rustix `0.38+`: - `tempfile = "3.7"` (3.7.0 is the first to require `rustix = "0.38"`) - `is-terminal = "0.4.8"` (0.4.8 is the first to require `rustix = "0.38"`) Normal builds are unaffected: the resolver already picks `tempfile 3.15.0` and `is-terminal 0.4.15`. Verified locally with `cargo +nightly update -Zminimal-versions` and `cargo +nightly build --workspace`: the lockfile resolves to a single `rustix v0.38.0`, no `rustix v0.37.x` anywhere in the tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Minimal versionsjob has been red onmainsince 2026-05-07. Root cause is two transitive paths pullingrustix = "0.37":proptest 1.6.0 -> tempfile 3.0 -> rustix 0.37codspeed-criterion-compat 4.0.1 -> is-terminal 0.4.6 -> rustix 0.37rustix
0.37.xusesrustc_layout_scalar_valid_range_start, the perma-unstable attribute removed from the compiler in rust-lang/rust#155433 (merged 2026-05-03). Tracking issue: bytecodealliance/rustix#1620. The 0.37 line is in deep maintenance (0.37.28 released 2025-01-07) and no backport is in flight.This adds two direct dev-dep floors, the minimum each path needs to land on rustix
0.38+:tempfile = "3.7"(3.7.0 is the first to requirerustix = "0.38")is-terminal = "0.4.8"(0.4.8 is the first to requirerustix = "0.38")Normal builds are unaffected: the resolver already picks
tempfile 3.15.0andis-terminal 0.4.15.Verified locally with
cargo +nightly update -Zminimal-versions && cargo +nightly build --workspace: the lockfile resolves to a singlerustix v0.38.0, norustix v0.37.xanywhere in the tree.AI assistance
Diagnosis, dep-chain trace, and Cargo.toml diff drafted with AI assistance and verified locally against the failing CI job. Reviewed and own the change.