-
Notifications
You must be signed in to change notification settings - Fork 44
Addressing PR comments #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Claude
wants to merge
8
commits into
main
Choose a base branch
from
claude/add-ctrl-tab-for-tabs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b6df8fd
Initial plan
Claude 6ce03db
Add Ctrl+Tab keyboard navigation for device information tabs
Claude 9427d82
Support Ctrl+Tab navigation for Advanced tab sub-tabs
Claude 3373750
Update src/gui/gsc_info_window.cpp
ashaduri b167098
Update src/gui/gsc_info_window.cpp
ashaduri dcce1f1
Update src/gui/gsc_info_window.cpp
ashaduri 980d0f1
Fix build issues: clean up corrupted function and properly structure …
Claude b7cfa45
Fix Advanced tab detection: only cycle sub-tabs when Advanced is active
Claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
advanced_notebook->get_visible()reflects the widget's “visible” property, not whether the Advanced page is currently the active page inmain_notebook. If Advanced has 2+ visible sub-tabs, this will consume Ctrl+Tab even when the user is on another main tab (it will change the hidden sub-tab selection and return true), so main tab switching won’t work.Consider gating sub-tab cycling on the Advanced page being the current
main_notebookpage (e.g., comparemain_notebook->get_nth_page(main_notebook->get_current_page())against theadvanced_tab_vboxwidget / usepage_num()), or checkadvanced_notebook->get_mapped()/is_drawable()instead ofget_visible()before handling the event.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude[agent] Fix by checking whether current tab is Advanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b6df8fd. Now checks if Advanced tab is the current active page using
page_num()before handling sub-tab cycling. This prevents Ctrl+Tab from being consumed when the user is on other main tabs.