Repository navigation
improvement: add oban option to AshOban.Signals - #228
Merged
Merged
Conversation
jeffhuen
force-pushed
the
signals-oban-option
branch
from
October 23, 2026 18:16
d7314ea to
62861c0
Compare
zachdaniel
approved these changes
Oct 24, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AshOban.Signalsalways inserts jobs into the defaultObaninstance. An app that runs a second instance, for example on another repo, cannot send a listener's jobs to it. If the emitting resource uses that other repo, AshOban also inserts the jobs outside the action's transaction.This PR adds an
obandelivery option. Its default isOban:AshOban.config/3now requires only the queues of listeners that use the instance it configures.Contributor checklist
Leave anything that you believe does not apply unchecked.