Repository navigation
fix: don't make worker and scheduler module names compile-time dependencies - #224
Merged
zachdaniel merged 1 commit intoOct 20, 2026
Merged
Conversation
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trigger's
worker_module_nameandscheduler_module_name, and a scheduled action'sworker_module_name, make the module that declares them depend at compile time on the modules they name. AshOban defines those modules while compiling the resource, so a trigger declared in a fragment forms a compile-connected cycle with its resource.AshOban only uses these names to define the modules, so nothing needs them at compile time. This lists them in
no_depend_modules, alongsideactor_persister.