feat(nextjs): export the remaining components, the React SDK hooks and the server actions - #566
Open
DonOmalVindula wants to merge 1 commit into
Open
Conversation
…d the server actions - The client entry now exports Loading and OrganizationList, and re-exports the React SDK hooks (useUser, useOrganization, useTranslation, useTheme, useBrandingContext, useBranding, useFlow, useI18n, useForm) so apps do not need their own dependency on @asgardeo/react, which would bring a second copy of the contexts. - The server entry exports the server actions (clearSession, isSignedIn, getSessionPayload, getUser, getUserProfile, httpRequest, signOut, switchOrganization, the organization actions, ...) as the JSDoc examples already assumed, and the asgardeo() helper gained isSignedIn, getSession, getUser, getUserProfile, signOut and clearSession. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LoadingandOrganizationListexist in the package but were not exported.useUser,useOrganization,useTranslation,useTheme, ...) were not re-exported, so applications had to import them from@asgardeo/react.@asgardeo/reactis a dependency of this package, not a peer, so an application's own copy can end up as a second instance with unrelated React contexts anduseUser()then returns nothing.@asgardeo/nextjs/serverexported onlyasgardeoandAsgardeoProvider. The server actions were unreachable, althoughclearSession's own JSDoc showsimport {clearSession} from '@asgardeo/nextjs/server', and theasgardeo()helper had no way to check the session or read the user.Fix
Loading,OrganizationList(with their prop types) and the React SDK hooks are exported.clearSession,createOrganization,getAccessToken,getAllOrganizations,getMyOrganizations,getOrganization,getSessionId,getSessionPayload,getUser,getUserProfile,httpRequest,isSignedIn,refreshToken,signOut,switchOrganization,updateUserProfile) together with theSessionTokenPayload,RefreshResultandHttpRequestActionResulttypes.asgardeo()gainedisSignedIn,getSession,getUser,getUserProfile,signOutandclearSession, with a usage example in its JSDoc.Testing
pnpm lint,tsc --noEmit.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code