fix(nextjs): stop protectRoute from redirecting to the protected route itself - #561
Open
DonOmalVindula wants to merge 1 commit into
Open
Conversation
…e itself Without a configured signInUrl, protectRoute redirected unauthenticated requests to the same-origin referer. Browsers keep the referer of the page that started the navigation across a redirect chain, so a protected page whose referer was itself bounced until ERR_TOO_MANY_REDIRECTS. - Use the referer only when it is a different page. - Answer 401 with a hint when the resolved target is the protected route itself (sign-in page covered by the protected matcher, or `/` protected without a signInUrl) instead of redirecting. - Drop the JSDoc mention of a `defaultRedirect` option that never existed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When neither
protectRoute({redirect})norsignInUrlis configured, the middleware redirected unauthenticated requests to the same-origin referer. Browsers keep the referer of the page that initiated a navigation across the whole redirect chain, so once the session expired while the user was on a protected page and they followed a link to another protected page, each redirect carried the same referer and the browser looped untilERR_TOO_MANY_REDIRECTS. The same happened when the configured sign-in target was itself covered by the protected matcher, or/was protected without asignInUrl. The JSDoc also listed aresolvedOptions.defaultRedirectfallback that does not exist.Fix
401(plain text with a hint to configuresignInUrl/NEXT_PUBLIC_ASGARDEO_SIGN_IN_URLor exclude the sign-in page from the protected routes) instead of redirecting.Testing
next/serverrequests: configuredsignInUrl,redirectoption precedence, same-origin referer, cross-origin referer ignored, referer equal to the protected page, sign-in target equal to the protected route (401), protected root without a target (401). 67 tests pass.pnpm lintandtsc --noEmitfor@asgardeo/nextjs.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code