fix(nextjs): refresh the organization list after an organization is created - #559
Open
DonOmalVindula wants to merge 1 commit into
Open
fix(nextjs): refresh the organization list after an organization is created#559DonOmalVindula wants to merge 1 commit into
DonOmalVindula wants to merge 1 commit into
Conversation
…reated AsgardeoProvider never passed a revalidateMyOrganizations function to the organization context, so CreateOrganization skipped the refresh and the switcher kept the old list until a reload. The server provider now passes the getMyOrganizations action, and the client provider keeps the list in state and updates it when the action resolves, as the React SDK does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OrganizationProviderexpects arevalidateMyOrganizationsfunction, and<CreateOrganization />calls it after a successful creation so the organization list reflects the new organization. The Next.js server provider never passed one (the client provider forwardedundefined as any), so the refresh was skipped and<OrganizationSwitcher />kept showing the old list until the page was reloaded. The React SDK re-fetches the list.Fix
AsgardeoServerProviderpasses the existinggetMyOrganizationsserver action asrevalidateMyOrganizations.AsgardeoClientProviderkeepsmyOrganizationsin state (initialised from and synced with the server-provided list) and, when revalidation is requested, calls the action and stores the result so every consumer of the organization context sees the new list.Testing
pnpm lint,tsc --noEmitandpnpm vitest run(60 tests) for@asgardeo/nextjs. There is no component test setup in this package, so the provider change is covered by review.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code