Skip to content

fix(deps): clear the rustls, zip and source-map-js advisories - #92

Merged
asdfghj1237890 merged 1 commit into
masterfrom
fix/deps-advisories-2026-10
Oct 19, 2026
Merged

asdfghj1237890 merged 1 commit into
masterfrom
fix/deps-advisories-2026-10

Conversation

@asdfghj1237890

Copy link
Copy Markdown
Owner

Summary

  • rustls 0.23.45 → 0.23.46 in both web/steam-core/Cargo.lock and web/src-tauri/Cargo.lock.
    • Fixes RUSTSEC-2026-0346 (medium), plus -0347, -0348 and -0349 (low), all published 2026-10-14.
    • 0.23.46 is inside the 7-day cooldown. .github/dependabot.yml exempts security updates from it.
  • source-map-js 1.2.1 → 1.2.2 in web/package-lock.json. It is a build-time dependency only.
  • tauri-plugin-updater now builds without its default zip feature: default-features = false, features = ["rustls-tls", "system-proxy"].
    • That removes zip 4.6.1 from the lockfile, together with arbitrary and derive_arbitrary. zip 4.6.1 has RUSTSEC-2026-0367 (high), -0368 and -0369 (critical).
    • No upgrade fixes it yet. Every updater release up to 2.14.0 (and 3.0.0-alpha.3) still requires zip ^4. Upstream merged zip 9 in chore(deps): update rust crate zip to v9 tauri-apps/plugins-workspace#3698 but hasn't released it.
    • The feature only unpacks .zip update bundles on Windows (and AppImage archives on Linux). With createUpdaterArtifacts: true, releases ship the signed NSIS -setup.exe and the macOS .app.tar.gz (see the v1.4.2 assets), and neither goes through it.
    • Behaviour change: a .zip update now fails with InvalidUpdaterFormat instead of being unpacked.
    • The app only calls tauri_plugin_updater::Builder::new().build(). Nothing it uses depends on the feature.
  • Why every Dependabot PR is red: since these advisories came out, the frontend job (npm audit gate) and the Rust dependency audit job fail on all the open Dependabot PRs, and master would fail the same way.
    • The audit job checks steam-core's lockfile first and stops at the first failure. That is why the zip advisories never appeared in those runs.

Verification

Run locally on Windows with Node 24.18, Rust 1.96 and cargo-audit 0.22.2.

  • npm ci, typecheck, lint, test:coverage (246/246, thresholds met) and build all pass.
  • test:e2e passes 16/16 on Chromium. Firefox and WebKit aren't installed locally; CI covers them.
  • test:rust, lint:rust (fmt and clippy -D warnings) and test:native (debug build and native worker smoke test) pass. They were re-run after the feature change.
  • node scripts/audit-gate.mjs passes, and cargo audit --deny warnings is clean on both lockfiles (55 and 493 crates). The audit job's GTK-exception check also passes.
  • Not verified here: the macOS build (CI's macOS job covers it) and a real in-app update, which only the next release can show.

After this merges, each of the other open Dependabot PRs needs an @dependabot rebase comment so its CI re-runs on top of this.

🤖 Generated with Claude Code

Advisories published after master's last CI run fail the audit jobs on
every open Dependabot PR:

- rustls 0.23.45 -> 0.23.46 in both lockfiles: RUSTSEC-2026-0346
  (medium), -0347, -0348 and -0349 (low).
- source-map-js 1.2.1 -> 1.2.2, a build-time dependency:
  GHSA-68fv-2mgg-jv7q (high). Supersedes #91.
- zip 4.6.1, through tauri-plugin-updater: RUSTSEC-2026-0367 (high),
  -0368 and -0369 (critical). No updater release depends on zip 9 yet
  (tauri-apps/plugins-workspace#3698 is merged but unreleased), so the
  plugin's default `zip` feature is dropped instead. That feature only
  unpacks .zip update bundles on Windows and AppImage archives on Linux.
  Releases (createUpdaterArtifacts: true) ship the signed NSIS
  -setup.exe and the macOS .app.tar.gz, and neither goes through it. A
  .zip update now fails with InvalidUpdaterFormat instead of being
  unpacked. zip, arbitrary and derive_arbitrary leave the lockfile.

rustls 0.23.46 is four days old, inside the 7-day cooldown, which
exempts security updates (.github/dependabot.yml).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@asdfghj1237890
asdfghj1237890 merged commit 1ef57ee into master Oct 19, 2026
7 checks passed
@asdfghj1237890
asdfghj1237890 deleted the fix/deps-advisories-2026-10 branch October 19, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant