Repository navigation
fix(alerts): enumerate topic-scoped SNS actions — sns:* fails at apply - #62
Merged
Merged
Conversation
…cAttributes
First live apply failed: SNS rejects wildcard actions in topic policies
('Invalid parameter: Policy statement action out of service scope') because
sns:* sweeps in account-level actions (CreateTopic, ListTopics) that cannot
apply to a topic resource. Use the explicit topic-scoped set AWS's own
__default_policy uses. CI could not catch this — it only surfaces on apply.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live apply of the detection pipeline failed at
aws_sns_topic_policy.alerts:SNS rejects wildcard actions in topic policies:
sns:*expands over account-level actions (CreateTopic,ListTopics, …) that cannot apply to a topic resource. AWS's own topic-policy examples (and the__default_policySNS generates) always enumerate the topic-scoped set — so this does the same for theAllowAccountManagementstatement. TheAllowEventBridgePublishstatement was already fine.No behavioral change for any current caller: the explicit list covers everything the account principal actually does with this topic.
This class of bug is invisible to CI (static scans only, no AWS credentials — the error only exists at
SetTopicAttributestime). Re-runningjust loonvault-applyafter merge completes the remaining resources.🤖 Generated with Claude Code