rk35xx-vendor: bump to 6.1.172 rkr7.2 sdk kernel - #10363
Conversation
📝 WalkthroughWalkthroughThe PR updates Rockchip vendor kernel branches to ChangesRockchip vendor kernel update
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
08
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml`:
- Line 8: Update the last-known-good-tag configuration to reference an existing
pushed tag in the configured Armbian Rockchip kernel repository, or the actual
commit corresponding to rk-6.1-rkr7.2; do not retain the unavailable v6.1.172
value.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ae9bb093-0430-4603-8c59-f7590c12c50b
📒 Files selected for processing (12)
config/kernel/linux-rk35xx-vendor.configconfig/kernel/linux-seeed-rk3576-vendor.configconfig/kernel/linux-seeed-rk3588-vendor.configconfig/sources/families/rk35xx.confconfig/sources/families/rockchip-rk3588.confconfig/sources/families/rockchip-rv1106.confconfig/sources/families/rockchip-rv1126.confconfig/sources/families/rockchip.confconfig/sources/families/seeed-rk3576.confconfig/sources/families/seeed-rk3588.confpatch/kernel/rk35xx-vendor-6.1/0000.patching_config.yamlpatch/kernel/rv1126-vendor-6.1/0000.patching_config.yaml
| branch: rk-6.1-rkr5.1 | ||
| last-known-good-tag: v6.1.115 | ||
| branch: rk-6.1-rkr7.2 | ||
| last-known-good-tag: v6.1.172 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
repo='https://github.com/armbian/linux-rockchip.git'
git ls-remote --exit-code --refs "$repo" \
'refs/heads/rk-6.1-rkr7.2' >/dev/null
git ls-remote --exit-code --refs "$repo" \
'refs/tags/v6.1.172' >/dev/nullRepository: armbian/build
Length of output: 151
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== file =="
cat -n patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml | sed -n '1,40'
echo
echo "== nearby config files =="
fd -a '.*patching_config\.yaml$' . | sed -n '1,50'
echo
echo "== configured source/tag refs =="
repo='https://github.com/armbian/linux-rockchip.git'
echo "refs/heads/rk-6.1-rkr7.2:"
git ls-remote --exit-code --refs "$repo" 'refs/heads/rk-6.1-rkr7.2' || echo "not found"
echo "refs/tags/v6.1.172:"
git ls-remote --exit-code --refs "$repo" 'refs/tags/v6.1.172' || echo "not found"
echo
echo "== related tags with v6.1.172 =="
git ls-remote --exit-code --tags "$repo" 'refs/tags/*v6.1.172*' || true
echo
echo "== tags around v6.1.172 =="
git ls-remote --exit-code --tags "$repo" 'refs/tags/v6.1.*' | sed 's#refs/tags/##' | sort -V | awk -v tag=v6.1.172 '
{a[NR]=$0; i[NR]=$0; n=NR}
END {
for(j=1;j<=n;j++) if(i[j]==tag) start=j-2;
if(!start) start=1;
end=start+20; if(end>n) end=n;
for(j=start;j<=end;j++) print i[j]
}' || true
echo
echo "== patching tool references =="
rg -n "last-known-good-tag|KERNELSOURCE|patching_config|0000\.patching_config|BASE_COMMIT|last known" patch .github scripts -g '*.sh' -g '*.yaml' -g '*.yml' -g '*.toml' | sed -n '1,120'Repository: armbian/build
Length of output: 209
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== directory listing =="
fd -a '0000\.patching_config\.yaml|patching_config\.yaml' .
fd -a '.*patching_config\.yaml$' .
echo
echo "== target config =="
if [ -f patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml ]; then
nl -ba patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml | sed -n '1,80'
else
echo "target file not found"
fi
echo
echo "== source refs =="
repo='https://github.com/armbian/linux-rockchip.git'
for ref in 'refs/heads/rk-6.1-rkr7.2' 'refs/tags/v6.1.172'; do
echo "--- $ref"
git ls-remote --exit-code --refs "$repo" "$ref" || echo "not found"
done
echo
echo "== v6.1.172 tags =="
git ls-remote --exit-code --tags "$repo" 'refs/tags/*v6.1.172*' || echo "none"
echo
echo "== patching config references =="
rg -n "last-known-good-tag|KERNELSOURCE|patching_config|0000\.patching_config|BASE_COMMIT|last known" patch .github scripts -g '*.sh' -g '*.yaml' -g '*.yml' -g '*.toml' 2>/dev/null | sed -n '1,160' || trueRepository: armbian/build
Length of output: 7398
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== target config =="
cat -n patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml | sed -n '1,80'
echo
echo "== source refs =="
repo='https://github.com/armbian/linux-rockchip.git'
for ref in 'refs/heads/rk-6.1-rkr7.2' 'refs/tags/v6.1.172'; do
echo "--- $ref"
git ls-remote --exit-code --heads --tags --symref "$repo" "$ref" || echo "not found"
done
echo
echo "== v6.1.172 tags =="
git ls-remote --exit-code --tags "$repo" 'refs/tags/*v6.1.172*' || echo "none"
echo
echo "== patching config references =="
rg -n "last-known-good-tag|KERNELSOURCE|patching_config|0000\.patching_config|BASE_COMMIT|last known" patch .github scripts -g '*.sh' -g '*.yaml' -g '*.yml' -g '*.toml' -g '*.env' 2>/dev/null | sed -n '1,200' || trueRepository: armbian/build
Length of output: 218
Use an existing kernel tag for last-known-good-tag.
https://github.com/armbian/linux-rockchip.git does not expose v6.1.172 as a tag, so patch base comparison or regeneration will fail against this configured source. Use a pushed tag or the actual commit used by rk-6.1-rkr7.2.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml` at line 8, Update
the last-known-good-tag configuration to reference an existing pushed tag in the
configured Armbian Rockchip kernel repository, or the actual commit
corresponding to rk-6.1-rkr7.2; do not retain the unavailable v6.1.172 value.
Source: MCP tools
There was a problem hiding this comment.
rk-6.1-rkr7.2 is not yet the default branch.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
repo='https://github.com/armbian/linux-rockchip.git'
for ref in \
'refs/heads/rk-6.1-rkr7.2' \
'refs/tags/v6.1.172' \
'refs/tags/v6.1.172^{}'
do
printf '%s: ' "$ref"
git ls-remote --refs "$repo" "$ref" || true
doneLength of output: 530
@nyanmisaka, acknowledged. The default branch does not affect this configuration because it names rk-6.1-rkr7.2 explicitly.
I confirmed that refs/heads/rk-6.1-rkr7.2 exists. However, refs/tags/v6.1.172 does not exist in armbian/linux-rockchip. The finding remains limited to last-known-good-tag.
🐇
✏️ Learnings added
Learnt from: nyanmisaka
Repo: armbian/build PR: 10363
File: patch/kernel/rk35xx-vendor-6.1/0000.patching_config.yaml:8-8
Timestamp: 2026-08-07T13:32:42.673Z
Learning: In the `armbian/linux-rockchip` repository, the `rk-6.1-rkr7.2` branch is intentionally not the default branch. Armbian kernel patching configuration can still select it through an explicit `branch: rk-6.1-rkr7.2` value.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
You are interacting with an AI system.
There was a problem hiding this comment.
actually keeping v6.1.115 as last known good tag is correct because the new one has to prove itself to be known good first.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
actually keeping v6.1.115 as last known good tag is correct because the new one has to prove itself to be known good first.
That makes sense. I'm a little confused about what this is for.
There was a problem hiding this comment.
i believe it is not even used, just purely informational.
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
igorpecovnik
added
11
3 participants
Description
How Has This Been Tested?
Summary by CodeRabbit
New Features
Bug Fixes
Chores