board: rk3588: switch reComputer RK3588 to Panthor open-source GPU stack - #10320
Open
Mkiring wants to merge 4 commits into
Open
board: rk3588: switch reComputer RK3588 to Panthor open-source GPU stack#10320Mkiring wants to merge 4 commits into
Mkiring wants to merge 4 commits into
Conversation
The proprietary Mali/Bifrost GPU driver (mali-valhall-g610 / libmali) has poor compatibility with newer Debian releases and desktop environments, causing the desktop to fail to start. Switch the reComputer RK3588 DevKit to the upstream Panthor DRM driver + Mesa userspace stack. Changes: - Kernel: enable CONFIG_DRM_PANTHOR, disable all Mali/Bifrost configs - Boot: add RECOMPUTER_GPU_STACK="panthor" and load the panthor DT overlay - Rootfs: skip proprietary libmali, install Mesa from bookworm-backports - Firmware: ship mali_csffw.bin required by Panthor - Cleanup: remove Mali EGL/GBM wrapper leftovers when using Panthor
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe RK3588 board configuration now supports the Panthor GPU stack. It enables the Panthor kernel driver, installs Mesa packages, removes conflicting Mali userspace files, selects Mesa GBM, and embeds required firmware in initramfs images. ChangesPanthor GPU stack
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant BoardConfig as RK3588 board configuration
participant KernelConfig as Kernel configuration
participant DebianRootfs as Debian rootfs
participant Initramfs as Initramfs builder
BoardConfig->>KernelConfig: Enable CONFIG_DRM_PANTHOR and disable legacy Mali options
BoardConfig->>DebianRootfs: Install Mesa packages from Bookworm backports
DebianRootfs->>DebianRootfs: Remove Mali userspace files and select Mesa GBM
BoardConfig->>Initramfs: Locate mali_csffw.bin and install the firmware hook
Initramfs->>Initramfs: Embed Panthor firmware in generated images
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
08
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/boards/recomputer-rk3588-devkit.conf`:
- Around line 97-108: Update the generated panthor-firmware hook script to
handle the mkinitramfs prereqs invocation before sourcing hook functions or
copying firmware: when $1 is prereqs, print the hook’s prerequisites (none) and
exit successfully. Keep the existing firmware installation flow for normal
invocations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e61d6e40-a5fd-4a90-8bf0-763282c830b1
📒 Files selected for processing (3)
config/boards/recomputer-rk3588-devkit.confconfig/kernel/linux-seeed-rk3588-vendor.configconfig/sources/vendors/seeed-studio/recomputer-rk35xx-common.inc
mkinitramfs calls each hook first with $1=prereqs to query dependencies, then again to perform the actual work. Add the standard prereqs guard so the hook prints an empty dependency list and exits before running mkdir/cp. The previous form worked in practice — mkinitramfs exports DESTDIR before the prereqs query (verified against initramfs-tools 0.151, and confirmed by the built initrd containing mali_csffw.bin), so the cp did not fail. But it relied on that invariant and ran side effects during a metadata-only call. Following the documented hook contract makes the behavior explicit and forward-compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proprietary Mali/Bifrost GPU driver (mali-valhall-g610 / libmali) has poor compatibility with newer Debian releases and desktop environments, causing the desktop to fail to start. Switch the reComputer RK3588 DevKit to the upstream Panthor DRM driver + Mesa userspace stack.
Changes:
Summary by CodeRabbit