maintenance-rewrite-kernel-patches: enable parallel patch rewriting - #10308
Open
igorpecovnik wants to merge 1 commit into
Open
maintenance-rewrite-kernel-patches: enable parallel patch rewriting#10308igorpecovnik wants to merge 1 commit into
igorpecovnik wants to merge 1 commit into
Conversation
Wire the parallel patch rewriting feature (lib/tools/common/patching_parallel.py, introduced in 205a36f) into the rewrite-patches workflow: pass PARALLEL_PATCHES to compile.sh, exposed as a dispatch toggle defaulting to yes with an escape hatch. It only takes effect for the rewrite-* commands this workflow runs (patching.py gates parallel on REWRITE_PATCHES=yes), and the worker count auto-calculates. Note: this belongs here, not in maintenance-rewrite-kernel-configs.yml — rewrite-kernel-config does not rewrite patches, so PARALLEL_PATCHES is a no-op there. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Contributor
📝 WalkthroughWalkthroughThe maintenance workflow adds a ChangesParallel patch rewrite workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the recently added parallel patch rewriting feature (
lib/tools/common/patching_parallel.py, introduced in205a36f2) into the rewrite-patches maintenance workflow.Change
parallel_patches(choice, default yes, withnoas an escape hatch if a board misbehaves).PARALLEL_PATCHESto./compile.sh … rewrite-kernel-patches|rewrite-uboot-patches.PARALLEL_WORKERSis left unset so the worker count auto-calculates.Why here, not the configs workflow
You pointed at
maintenance-rewrite-kernel-configs.yml, but the feature can't work there. The gate inlib/tools/patching.pyis:rewrite_patches_in_placeis only true whenREWRITE_PATCHES=yes— i.e. therewrite-kernel-patches/rewrite-uboot-patchescommands, which live in this workflow.rewrite-kernel-confignever sets it, soPARALLEL_PATCHESwould be a no-op in the configs workflow. Bothwhattodooptions here setREWRITE_PATCHES=yes, so the toggle applies to kernel and u-boot patch rewrites alike.Summary by CodeRabbit