Skip to content

fix: remove struct constraint from Guard.Against.Expression to support reference types (#339) #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Moha-sami wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −5
Open

fix: remove struct constraint from Guard.Against.Expression to support reference types (#339) #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c09a8e5
fix: remove struct constraint from Guard.Against.Expression to suppor…
Moha-sami Aug 1, 2026
c802c83
Merge branch 'main' into fix-expression-reference-types
ardalis Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/GuardClauses/GuardAgainstExpressionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Threading.Tasks;
using System.Runtime.CompilerServices;

Expand Down Expand Up @@ -27,7 +27,6 @@ public static T Expression<T>(this IGuardClause guardClause,
string message,
[CallerArgumentExpression("input")] string? parameterName = null,
Func<Exception>? exceptionCreator = null)
where T : struct
{
if (func(input))
{
Expand Down Expand Up @@ -60,7 +59,6 @@ public static async Task<T> ExpressionAsync<T>(this IGuardClause guardClause,
string message,
[CallerArgumentExpression("input")] string? parameterName = null,
Func<Exception>? exceptionCreator = null)
where T : struct
{
if (await func(input))
{
Expand Down
22 changes: 20 additions & 2 deletions test/GuardClauses.UnitTests/GuardAgainstExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using Ardalis.GuardClauses;
using Xunit;
Expand Down Expand Up @@ -98,7 +98,25 @@
var exception = Assert.Throws<ArgumentException>(() => Guard.Against.Expression(x => x == 2, 2, "custom message", paramName));
Assert.NotNull(exception);
Assert.NotNull(exception.Message);
Assert.Equal(paramName, exception.ParamName);
Assert.Contains(paramName, exception.Message);
}

public class CustomClass
{
public string Name { get; set; } = string.Empty;
}

[Fact]
public void GivenReferenceTypeWhenTheExpressionEvaluatesToTrueThrowsException()
{
var testCase = new CustomClass { Name = "Test" };
Assert.Throws<ArgumentException>(() => Guard.Against.Expression((x) => x.Name == "Test", testCase, "Name cannot be Test"));
}

[Fact]
public void GivenReferenceTypeWhenTheExpressionEvaluatesToFalseDoesNothing()

Check failure on line 117 in test/GuardClauses.UnitTests/GuardAgainstExpression.cs

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 


See more on https://sonarcloud.io/project/issues?id=ardalis_GuardClauses&issues=AaAQz2Fonr57X1Rx7Vsu&open=AaAQz2Fonr57X1Rx7Vsu&pullRequest=406
{
var testCase = new CustomClass { Name = "Test" };
Guard.Against.Expression((x) => x.Name == "Other", testCase, "Name cannot be Other");
}
}
Loading