Repository navigation
🚨 suppress intentional forge 1.8 lint findings - #241
Merged
Merged
Conversation
j-vp
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the forge 1.8 lint findings that are intentional with inline directives, per site in src and at contract level in the tests. Rules that fire across the whole codebase go in exclude_lints instead.
Needs forge 1.8.1, directives on findings reported in an inherited file were ignored before that.
Also drops dynamic_test_linking = false and unchecked_cheatcode_artifacts = true. Both were only needed because the artifact lookup broke when the artifact list is disabled, see foundry-rs/foundry#16468.