fix: invalid font-size gets chosen for a narrow viewport because it sits on a wide screen#607
Open
isaachilly wants to merge 1 commit into
Open
fix: invalid font-size gets chosen for a narrow viewport because it sits on a wide screen#607isaachilly wants to merge 1 commit into
isaachilly wants to merge 1 commit into
Conversation
|
Review changes with |
isaachilly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current use of device-width rather than width makes text on wide-screen monitors disproportionately large. Users with high-resolution monitors often split their screen into halves or thirds; forcing '4K styles' onto a 1280px-wide window breaks the intended design.
Oversized fonts triggered in a small window cause layout smashing and horizontal scrolling.
We should align with modern standards by treating the window viewport as the primary source of truth.
Issue reported in #38 and fixed in #53 but PR was not merged and closed, maybe due to its additional changes.