Skip to content

feat(schema): add database schema config #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serrovsky wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(schema): add database schema config #1129

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef40200
chore(message): fix wrong PGSQL_DBNAME error message
Mar 26, 2022
3dddaca
feat(schema): add database schema config
Mar 26, 2022
7ffa4a0
chore: change no schema set info log
Mar 27, 2022
45fb199
Merge branch 'main' into feat/add-schema-to-db
mozillazg Mar 28, 2022
dcb167c
Update cmd/database.go
serrovsky Mar 28, 2022
f76b70a
chore: move db var to savePgsql function
Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion cmd/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/spf13/viper"
"gorm.io/driver/postgres"
"gorm.io/gorm"
"gorm.io/gorm/schema"
)

type PsqlConnInfo struct {
Expand All @@ -17,6 +18,7 @@ type PsqlConnInfo struct {
DbName string
SslMode string
Password string
Schema string
}

func getPsqlConnInfo() (PsqlConnInfo, error) {
Expand Down Expand Up @@ -55,12 +57,21 @@ func getPsqlConnInfo() (PsqlConnInfo, error) {
return PsqlConnInfo{}, fmt.Errorf("%s_PGSQL_PASSWORD env var is required", envVarsPrefix)
}

var schema string
if value := viper.GetString("PGSQL_SCHEMA"); value != "" {
schema = value
} else {
schema = ""
glog.V(2).Info("No schema set.")
}
Comment on lines +61 to +66
Copy link
Copy Markdown
Contributor

@chen-keinan chen-keinan Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if value := viper.GetString("PGSQL_SCHEMA"); value != "" {
schema = value
} else {
schema = ""
glog.V(2).Info("No schema set.")
}
schema = viper.GetString("PGSQL_SCHEMA")


return PsqlConnInfo{
Host: host,
User: user,
DbName: dbName,
SslMode: sslMode,
Password: password,
Schema: schema,
}, nil
}

Expand Down Expand Up @@ -97,7 +108,18 @@ func savePgsql(jsonInfo string) {
exitWithError(err)
}

db, err := gorm.Open(postgres.Open(PsqlConnInfo.toString()), &gorm.Config{})
var db *gorm.DB

if PsqlConnInfo.Schema == "" {
Comment thread
serrovsky marked this conversation as resolved.
Copy link
Copy Markdown
Contributor

@chen-keinan chen-keinan Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if PsqlConnInfo.Schema == "" {
if PsqlConnInfo.Schema == "" {
glog.V(2).Info("No schema set.")

db, err = gorm.Open(postgres.Open(PsqlConnInfo.toString()), &gorm.Config{})
} else {
db, err = gorm.Open(postgres.Open(PsqlConnInfo.toString()), &gorm.Config{
NamingStrategy: schema.NamingStrategy{
TablePrefix: fmt.Sprintf("%s.", PsqlConnInfo.Schema), // schema name
SingularTable: false,
}})
}

if err != nil {
exitWithError(fmt.Errorf("received error connecting to database: %s", err))
}
Expand Down