Skip to content

Add import destructuring and amends/extends of classes within modules #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HT154 wants to merge 2 commits into
base: main
Choose a base branch
from

Formatter/GenericParser support

3cbd6ff
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Add import destructuring and amends/extends of classes within modules #1461

Formatter/GenericParser support
3cbd6ff
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results failed Mar 6, 2026 in 0s

1 fail, 20 pass in 4s

 7 files  ±0   7 suites  ±0   4s ⏱️ ±0s
21 tests ±0  20 ✅ ±0  0 💤 ±0  1 ❌ ±0 
35 runs  ±0  34 ✅ ±0  0 💤 ±0  1 ❌ ±0 

Results for commit 3cbd6ff. ± Comparison against earlier commit 093f071.

Annotations

Check warning on line 0 in org.pkl.parser.ParserComparisonTest

See this annotation in the file changed.

@github-actions github-actions / Test Results

compareSnippetTests() (org.pkl.parser.ParserComparisonTest) failed 

artifacts/test-results-xml-gradle-check/pkl-parser/build/test-results/test/TEST-org.pkl.parser.ParserComparisonTest.xml [took 3s]
Raw output 
org.assertj.core.error.AssertJMultipleFailuresError: 
Multiple Failures (2 failures)
-- failure 1 --
[path: ../pkl-core/src/test/files/LanguageSnippetTests/input/basic/import5.pkl] 
expected: 
  "(module
    (importClause
      (stringChars))
    (clazz
      (identifier)
      (classBody))
    (classProperty
      (identifier)
      (newExpr
        (declaredType
          (qualifiedIdentifier
            (identifier)))
        (objectBody))))"
 but was: 
  "(module
    (importClause
      (stringChars)
      (importDeconstructionList
        (importDeconstructionListElements
          (importDeconstruction
            (identifier)
            (identifier)))))
    (clazz
      (identifier)
      (classBody))
    (classProperty
      (identifier)
      (newExpr
        (declaredType
          (qualifiedIdentifier
            (identifier)))
        (objectBody))))"
at ParserComparisonTest.compare(ParserComparisonTest.java:67)
-- failure 2 --
[path: ../pkl-core/src/test/files/LanguageSnippetTests/input/basic/import4.pkl] 
expected: 
  "(module
    (importClause
      (stringChars)
      (identifier))
    (importClause
      (stringChars)
      (identifier))
    (importClause
      (stringChars))
    (classProperty
      (identifier)
      (unqualifiedAccessExpr
        (identifier)))
    (classProperty
      (identifier)
      (typeAnnotation
        (declaredType
          (qualifiedIdentifier
            (identifier))))
      (newExpr
        (objectBody
          (objectProperty
            (identifier)
            (intLiteralExpr)))))
    (classProperty
      (identifier)
      (unqualifiedAccessExpr
        (identifier)))
    (classProperty
      (identifier)
      (typeAnnotation
        (declaredType
          (qualifiedIdentifier
            (identifier))))
      (newExpr
        (objectBody
          (objectProperty
            (identifier)
            (intLiteralExpr)))))
    (classProperty
      (identifier)
      (qualifiedAccessExpr
        (unqualifiedAccessExpr
          (identifier))
        (unqualifiedAccessExpr
          (identifier)
          (argumentList
            (functionLiteralExpr
              (parameterList)
              (newExpr
                (declaredType
                  (qualifiedIdentifier
                    (identifier)))
                (objectBody)))))))
    (classProperty
      (identifier)
      (qualifiedAccessExpr
        (unqualifiedAccessExpr
          (identifier))
        (unqualifiedAccessExpr
          (identifier)
          (argumentList
            (functionLiteralExpr
              (parameterList)
              (newExpr
                (declaredType
                  (qualifiedIdentifier
                    (identifier)))
                (objectBody)))))))
    (classProperty
      (identifier)
      (qualifiedAccessExpr
        (unqualifiedAccessExpr
          (identifier))
        (unqualifiedAccessExpr
          (identifier)
          (argumentList
            (functionLiteralExpr
              (parameterList)
              (newExpr
                (declaredType
                  (qualifiedIdentifier
                    (identifier)))
                (objectBody))))))))"
 but was: 
  "(module
    (importClause
      (stringChars)
      (identifier)
      (importDeconstructionList
        (importDeconstructionListElements
          (importDeconstruction
            (identifier)
            (identifier))
          (importDeconstruction
            (identifier)))))
    (importClause
      (stringChars)
      (identifier)
      (importDeconstructionList
        (importDeconstructionListElements
          (importDeconstruction
            (identifier)
            (identifier))
          (importDeconstruction
            (identifier)
            (identifier)))))
    (importClause
      (stringChars))
    (classProperty
      (identifier)
      (unqualifiedAccessExpr
        (identifier)))
    (classProperty
      (identifier)
      (typeAnnotation
        (declaredType
          (qualifiedIdentifier
            (identifier))))
      (newExpr
        (objectBody
          (objectProperty
            (identifier)
            (intLiteralExpr)))))
    (classProperty
      (identifier)
      (unqualifiedAccessExpr
        (identifier)))
    (classProperty
      (identifier)
      (typeAnnotation
        (declaredType
          (qualifiedIdentifier
            (identifier))))
      (newExpr
        (objectBody
          (objectProperty
            (identifier)
            (intLiteralExpr)))))
    (classProperty
      (identifier)
      (qualifiedAccessExpr
        (unqualifiedAccessExpr
          (identifier))
        (unqualifiedAccessExpr
          (identifier)
          (argumentList
            (functionLiteralExpr
              (parameterList)
              (newExpr
                (declaredType
                  (qualifiedIdentifier
                    (identifier)))
                (objectBody)))))))
    (classProperty
      (identifier)
      (qualifiedAccessExpr
        (unqualifiedAccessExpr
          (identifier))
        (unqualifiedAccessExpr
          (identifier)
          (argumentList
            (functionLiteralExpr
              (parameterList)
              (newExpr
                (declaredType
                  (qualifiedIdentifier
                    (identifier)))
                (objectBody)))))))
    (classProperty
      (identifier)
      (qualifiedAccessExpr
        (unqualifiedAccessExpr
          (identifier))
        (unqualifiedAccessExpr
          (identifier)
          (argumentList
            (functionLiteralExpr
              (parameterList)
              (newExpr
                (declaredType
                  (qualifiedIdentifier
                    (identifier)))
                (objectBody))))))))"
at ParserComparisonTest.compare(ParserComparisonTest.java:67)
	at app//org.pkl.parser.ParserComparisonTest.compareSnippetTests(ParserComparisonTest.kt:35)
	at java.base@21.0.10/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base@21.0.10/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base@21.0.10/java.util.ArrayList.forEach(ArrayList.java:1596)

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Test Results

21 tests found 

There are 21 tests, see "Raw output" for the full list of tests.
Raw output 
org.pkl.commons.NameMapperTest ‑ empty prefixes everything()
org.pkl.commons.NameMapperTest ‑ implicit uppercase classname()
org.pkl.commons.NameMapperTest ‑ longest prefix wins()
org.pkl.commons.NameMapperTest ‑ no implicit uppercased classname if explicitly renamed()
org.pkl.commons.ShlexTest ‑ adjacent quoted strings are one token()
org.pkl.commons.ShlexTest ‑ double quoted token parsing()
org.pkl.commons.ShlexTest ‑ empty input produces empty output()
org.pkl.commons.ShlexTest ‑ empty quotes produce a single empty token()
org.pkl.commons.ShlexTest ‑ escaping does not apply within single quotes()
org.pkl.commons.ShlexTest ‑ escaping handles double quotes()
org.pkl.commons.ShlexTest ‑ regular token parsing()
org.pkl.commons.ShlexTest ‑ single quoted token parsing()
org.pkl.commons.ShlexTest ‑ space escapes do not split tokens()
org.pkl.commons.ShlexTest ‑ whitespace input produces empty output()
org.pkl.parser.LexerTest ‑ acceptsAllUnicodeCodepointsInComments()
org.pkl.parser.LexerTest ‑ isRegularIdentifier()
org.pkl.parser.LexerTest ‑ lexSingleBacktick()
org.pkl.parser.LexerTest ‑ maybeQuoteIdentifier()
org.pkl.parser.LexerTest ‑ rejectsSentinelBetweenTokens()
org.pkl.parser.ParserComparisonTest ‑ compareSnippetTests()
org.pkl.parser.SpanTest ‑ endWith test()
View more details on GitHub Actions