Skip to content

Accept port 1 when validating published port ranges #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devops-thiago wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

Accept port 1 when validating published port ranges #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Services/ContainerAPIService/Client/Parser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,13 +701,13 @@ public struct Parser {
throw ContainerizationError(.invalidArgument, message: "invalid publish container port: \(containerPortText)")
}

guard hostPortRangeStart > 1,
guard hostPortRangeStart >= 1,
hostPortRangeStart <= hostPortRangeEnd
else {
throw ContainerizationError(.invalidArgument, message: "invalid publish host port range: \(hostPortText)")
}

guard containerPortRangeStart > 1,
guard containerPortRangeStart >= 1,
containerPortRangeStart <= containerPortRangeEnd
else {
throw ContainerizationError(.invalidArgument, message: "invalid publish container port range: \(containerPortText)")
Expand Down
9 changes: 9 additions & 0 deletions Tests/ContainerAPIClientTests/ParserTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,15 @@ struct ParserTest {
#expect(result[0].count == 1)
}

@Test
func testPublishPortOne() throws {
let result = try Parser.publishPorts(["127.0.0.1:1:1/tcp"])
#expect(result.count == 1)
#expect(result[0].hostPort == UInt16(1))
#expect(result[0].containerPort == UInt16(1))
#expect(result[0].count == 1)
}

@Test
func testPublishPortInvalidProtocol() throws {
#expect {
Expand Down