Skip to content

Split --label on the first '=' only so values may contain '=' #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chengboonrong wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

Split --label on the first '=' only so values may contain '=' #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Services/ContainerAPIService/Client/Parser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ public struct Parser {
if label.isEmpty {
throw ContainerizationError(.invalidArgument, message: "label cannot be an empty string")
}
let parts = label.split(separator: "=", maxSplits: 2)
// Split on the first `=` only, so a value may itself contain `=`
// (e.g. `--label 'rule=Host(`ex.com`)'`), matching `docker run --label`.
let parts = label.split(separator: "=", maxSplits: 1)
switch parts.count {
case 1:
result[String(parts[0])] = ""
Expand Down
16 changes: 16 additions & 0 deletions Tests/ContainerAPIClientTests/ParserTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,6 +1348,22 @@ struct ParserTest {
#expect(result["key99"] == "value99")
}

@Test("label value may contain '=' (split on first '=' only)")
func testLabelValueContainingEquals() throws {
let result = try Parser.labels([
"config=key=value",
"traefik.http.routers.x.rule=Host(`ex.com`)",
"plain=value",
"novalue",
"emptyvalue=",
])
#expect(result["config"] == "key=value")
#expect(result["traefik.http.routers.x.rule"] == "Host(`ex.com`)")
#expect(result["plain"] == "value")
#expect(result["novalue"] == "")
#expect(result["emptyvalue"] == "")
}

@Test("resolve with large input preserves all entries")
func testParseKeyValuePairsLargeInput() {
let pairs = (0..<100).map { "key\($0)=value\($0)" }
Expand Down