Skip to content

[builder]: enable ssh forwarding for container build#1508

Open
saehejkang wants to merge 1 commit into
apple:mainfrom
saehejkang:ssh-agent-access-build-commands
Open

[builder]: enable ssh forwarding for container build#1508
saehejkang wants to merge 1 commit into
apple:mainfrom
saehejkang:ssh-agent-access-build-commands

Conversation

@saehejkang

@saehejkang saehejkang commented May 6, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Closes #1472 and depends on apple/container-builder-shim#76 for pipeline to ✅

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@saehejkang
saehejkang force-pushed the ssh-agent-access-build-commands branch from ed08f5a to acdc87e Compare May 6, 2026 03:16
@JaewonHur
JaewonHur self-requested a review May 11, 2026 16:43
Comment thread Sources/ContainerCommands/BuildCommand.swift
Comment thread Sources/ContainerCommands/BuildCommand.swift
@JaewonHur

Copy link
Copy Markdown
Contributor

@saehejkang Hi! Sorry for inconvenience :(
I completely forgot to merge this...
Could you resolve conflict in that CLIBuilderTest.swift..?

Then, could you bump container-builder-shim version to 0.13.0 in Package.swift?

@saehejkang
saehejkang force-pushed the ssh-agent-access-build-commands branch from c3b8f83 to b4f0f1d Compare July 16, 2026 01:21
@JaewonHur

Copy link
Copy Markdown
Contributor

Could you bump the builderShimVersion in Package.swift to 0.13.0?

@JaewonHur
JaewonHur force-pushed the ssh-agent-access-build-commands branch from b4f0f1d to 6cf86ad Compare July 17, 2026 15:16
@JaewonHur

Copy link
Copy Markdown
Contributor

@saehejkang Hi! I rebased this PR as well to run the CI on updated container-builder-shim. Once all CI passed and you force push the commit, I'll merge. Thank you!

@JaewonHur

JaewonHur commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Could you resolve this error as well?

✘ Test testBuildWithSSHDefaultForwarding() recorded an issue at TestCLIBuilderSerial.swift:253:6: Caught error: .nonZeroExit(64, "Warning! Running debug build. Performance may be degraded.\nError: dockerfile not found in context dir\nUsage: container build [<options>] [<context-dir>]\n  See \'container build --help\' for more information.")

Especially, Error: dockerfile not found in context dir (in the error message).

@saehejkang
saehejkang force-pushed the ssh-agent-access-build-commands branch 4 times, most recently from a67b8f2 to 9f7a4d1 Compare July 18, 2026 02:38
@JaewonHur

Copy link
Copy Markdown
Contributor

Could you rebase this PR? We fixed the flaky tests.

@saehejkang
saehejkang force-pushed the ssh-agent-access-build-commands branch from 2a71a93 to e65ef51 Compare July 25, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: RUN commands in container build that require ssh agent access.

2 participants