Skip to content

[Fix] Collision checker concurrent handling #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivang1234gupta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Collision checker concurrent handling #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...iscovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/CollisionChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ public boolean check(long timeInMillis, int location) {
dataLock.lock();
try {
long resolvedTime = resolution.convert(timeInMillis, TimeUnit.MILLISECONDS);
// if currentInstant > resolvedTime then it means that bitset is already cleared for that particular resolvedTime
// which increases the chances of getting duplicated id generation
if (currentInstant > resolvedTime) {
return false;
}

if (currentInstant != resolvedTime) {
currentInstant = resolvedTime;
bitSet.clear();
Expand Down
28 changes: 23 additions & 5 deletions ...discovery-bundle/src/test/java/io/appform/ranger/discovery/bundle/id/IdGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import io.appform.ranger.discovery.bundle.id.constraints.impl.PartitionValidator;
import io.appform.ranger.discovery.bundle.id.formatter.IdFormatters;
import lombok.Getter;
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;
import lombok.val;
import org.awaitility.Awaitility;
Expand All @@ -31,11 +32,8 @@
import org.junit.jupiter.api.Test;

import java.time.*;
import java.util.Collections;
import java.util.Date;
import java.util.Optional;
import java.util.concurrent.Callable;
import java.util.concurrent.Executors;
import java.util.*;
import java.util.concurrent.*;
Copy link
Copy Markdown
Contributor

@r0goyal r0goyal Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert wildcard imports with individual imports. This would raise issues on sonar

import java.util.stream.IntStream;

/**
Expand Down Expand Up @@ -235,6 +233,26 @@ void testParseSuccessAfterGeneration() {
Assertions.assertEquals(parsedId.getGeneratedDate(), generatedId.getGeneratedDate());
}

@Test
@SneakyThrows
void testConcurrentIdGenerators() {
ExecutorService executorService = Executors.newFixedThreadPool(32);
ConcurrentSkipListSet<String> concurrentIds = new ConcurrentSkipListSet<>();
Long startTime = System.currentTimeMillis();
List<CompletableFuture> futures = new ArrayList<>();
for (int numThreads = 0; numThreads < 32; numThreads++) {
futures.add(CompletableFuture.runAsync(() -> {
for (int hits = 0; hits < 1000; hits++) {
Id id = IdGenerator.generate("0E");
concurrentIds.add(id.getId());
}
}, executorService));
}
CompletableFuture.allOf(futures.toArray(new CompletableFuture[32])).get();
Assertions.assertEquals(32000, concurrentIds.size());

}


@SuppressWarnings("SameParameterValue")
private Date generateDate(int year, int month, int day, int hour, int min, int sec, int ms, ZoneId zoneId) {
Expand Down