This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Adds missing peer dependency - #1196
Open
arcanis wants to merge 1 commit into
Open
Conversation
|
@arcanis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
======================================
Coverage 95.6% 95.6%
======================================
Files 22 22
Lines 1116 1116
Branches 174 162 -12
======================================
Hits 1067 1067
Misses 44 44
Partials 5 5Continue to review full report at Codecov.
|
This was referenced Nov 11, 2019
|
And there are few more; apollo-link-context also doesn't have peerDeps. I can't use apollo with yarn 2 because of this. Any plan to update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apollo-link-errorhas a transitive peer dependency ongraphqlthroughapollo-link, and must be marked as such. Cf my article why implicit transitive peer dependencies are bad 🙂As long as you're here, can you please give a look to the following related PRs? 😃
apollo-engine-reportingapollo-cache@apollo/react-hooks@apollo/react-ssr