Merged
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 51df5d1a7a793fb13cc13022 |
martinbonnin
commented
Jan 28, 2026
| public fun getChildren ()Ljava/util/List; | ||
| public final fun getDescription ()Ljava/lang/String; | ||
| public final fun getQualifiedName ()Ljava/lang/String; | ||
| public final fun getName ()Ljava/lang/String; |
Contributor
Author
There was a problem hiding this comment.
I'm advocating for name instead of identifier because there is name in many other places and I don't think we need specific language for this.
martinbonnin
commented
Jan 28, 2026
| public static final fun parseAsGraphQLRequest (Ljava/util/Map;)Ljava/lang/Object; | ||
| public static final fun parseAsGraphQLRequest (Lokio/BufferedSource;)Ljava/lang/Object; | ||
| public static final fun toExternalValueMap (Ljava/util/Map;)Ljava/lang/Object; | ||
| public static final fun toGraphQLRequest (Ljava/lang/String;)Lcom/apollographql/apollo/execution/GraphQLRequest; |
Contributor
Author
There was a problem hiding this comment.
Sneaky removal before it's too late. 🥷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See graphql/graphql-spec#1163