Implement @defer and @stream as of incremental/v0.2#6331
Merged
Conversation
Collaborator
✅ Docs Preview ReadyConfiguration{
"repoOverrides": {
"apollographql/apollo-kotlin@main": {
"remote": {
"owner": "apollographql",
"repo": "apollo-kotlin",
"branch": "defer-incremental-response-format-june-2023"
}
}
}
}
1 pages published. Build will be available for 30 days. |
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
from
e2da859 to
bb504f6
Compare
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 911dc892bc63c26d9ec34dd6 URL: https://www.apollographql.com/docs/deploy-preview/911dc892bc63c26d9ec34dd6 |
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
2 times, most recently
from
e1ee642 to
4fa99ad
Compare
Contributor
|
Apollo Client 4 introduces different handlers for different incremental formats. We could do the same while the format iterates. |
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
3 times, most recently
from
fc4f174 to
8dfc4b3
Compare
BoD
commented
Sep 24, 2025
...lo-api/src/commonMain/kotlin/com/apollographql/apollo/api/http/DefaultHttpRequestComposer.kt
Outdated
Show resolved
Hide resolved
...lo-api/src/commonMain/kotlin/com/apollographql/apollo/api/http/DefaultHttpRequestComposer.kt
Outdated
Show resolved
Hide resolved
...otlin/com/apollographql/apollo/internal/incremental/Defer20220824IncrementalResultsMerger.kt
Outdated
Show resolved
Hide resolved
.../commonMain/kotlin/com/apollographql/apollo/internal/incremental/IncrementalResultsMerger.kt
Outdated
Show resolved
Hide resolved
...-runtime/src/commonMain/kotlin/com/apollographql/apollo/network/http/HttpNetworkTransport.kt
Show resolved
Hide resolved
...-runtime/src/commonMain/kotlin/com/apollographql/apollo/network/http/HttpNetworkTransport.kt
Outdated
Show resolved
Hide resolved
BoD
commented
Sep 25, 2025
...Main/kotlin/com/apollographql/apollo/internal/incremental/IncrementalDeliveryProtocolImpl.kt
Outdated
Show resolved
Hide resolved
...-runtime/src/commonMain/kotlin/com/apollographql/apollo/network/http/HttpNetworkTransport.kt
Outdated
Show resolved
Hide resolved
...lo-api/src/commonMain/kotlin/com/apollographql/apollo/api/http/DefaultHttpRequestComposer.kt
Outdated
Show resolved
Hide resolved
...Main/kotlin/com/apollographql/apollo/internal/incremental/IncrementalDeliveryProtocolImpl.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/Executables.kt
Outdated
Show resolved
Hide resolved
...-runtime/src/commonMain/kotlin/com/apollographql/apollo/network/http/HttpNetworkTransport.kt
Show resolved
Hide resolved
…efaultHttpRequestComposer
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
from
76ff55c to
97177bd
Compare
Contributor
Author
|
I think we're all good now. |
BoD
changed the title
@defer and @stream as of incremental/v0.2
Contributor
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
A few comments but this looks good! Almost there!
| @@ -1,4 +1,4 @@ | |||
| name: defer-with-router-tests | |||
| name: defer-integration-tests | |||
| - run: | | ||
| ./router --supergraph tests/defer/router/simple-supergraph.graphqls & | ||
|
|
||
| - uses: gradle/actions/setup-gradle@dbbdc275be76ac10734476cc723d82dfe7ec6eda #v3.4.2 |
| - run: | | ||
| ./router --supergraph tests/defer/router/simple-supergraph.graphqls & | ||
|
|
||
| - uses: gradle/actions/setup-gradle@dbbdc275be76ac10734476cc723d82dfe7ec6eda #v3.4.2 |
...untime/src/commonMain/kotlin/com/apollographql/apollo/network/IncrementalDeliveryProtocol.kt
Outdated
Show resolved
Hide resolved
...lo-api/src/commonMain/kotlin/com/apollographql/apollo/api/http/DefaultHttpRequestComposer.kt
Show resolved
Hide resolved
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/BooleanExpression.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/BooleanExpression.kt
Outdated
Show resolved
Hide resolved
...-runtime/src/commonMain/kotlin/com/apollographql/apollo/network/http/HttpNetworkTransport.kt
Show resolved
Hide resolved
…pollo/api/http/DefaultHttpRequestComposer.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
…ql/apollo/network/IncrementalDeliveryProtocol.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
…pollo/api/BooleanExpression.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
…pollo/api/BooleanExpression.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
@streamand the new incremental response format specified by incremental/v0.2 and seen in examples and spec edits.A protocol can now be passed to the
HttpNetworkTransportto choose which to use (legacyv0.1/20220824is still the default).