Skip to content

Add support for @catch and @semanticNonNull#5405

Merged
martinbonnin merged 42 commits intomainfrom
add-nullability
Dec 1, 2023
Merged

Add support for @catch and @semanticNonNull#5405
martinbonnin merged 42 commits intomainfrom
add-nullability

Conversation

@martinbonnin
Copy link
Copy Markdown
Contributor

@martinbonnin martinbonnin commented Nov 27, 2023 •
edited
Loading

See apollographql/specs#36
Supersedes #5368

Remaining:

  • deprecate @nonnull ?

@martinbonnin martinbonnin requested a review from BoD as a code owner November 27, 2023 12:25
@martinbonnin martinbonnin mentioned this pull request Nov 27, 2023
Closed
BoD
BoD reviewed Nov 27, 2023
View reviewed changes
Comment thread libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Adapters.kt Outdated
Comment thread libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt Outdated
Comment thread libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt Outdated
Comment thread ...aries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/definitions.kt Outdated
Comment thread ...aries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/definitions.kt Outdated
Comment thread ...aries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/definitions.kt Outdated
Comment thread tests/catch/src/main/graphql/schema.graphqls Outdated
martinbonnin added a commit to apollographql/specs that referenced this pull request Nov 27, 2023
@martinbonnin
fixes from apollographql/apollo-kotlin#5405
cd8afbd 
Thanks @BoD
@martinbonnin martinbonnin force-pushed the remove-kotlin-labs-0.1 branch from eda4d56 to ed79b7e Compare November 27, 2023 17:17
@martinbonnin martinbonnin requested a review from a team as a code owner November 27, 2023 17:17
Base automatically changed from remove-kotlin-labs-0.1 to main November 27, 2023 17:49
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit f69d3c5
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6569d8d3bfa3fb0008c08c6e

This was referenced Nov 28, 2023
Open
Closed
Closed
Closed
Closed
@BoD BoD mentioned this pull request Nov 30, 2023
Closed
@martinbonnin martinbonnin requested a review from BoD November 30, 2023 13:35
BoD
BoD approved these changes Dec 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Adapters.kt Outdated
Comment thread libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt
Comment thread libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt Outdated
Comment thread libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt Outdated
Comment thread ...st/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/ExecutableValidationScope.kt Outdated
Comment thread ...aries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/definitions.kt Outdated
Comment thread ...apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/ir/IrOperationsBuilder.kt Outdated
martinbonnin and others added 14 commits December 1, 2023 11:48
@martinbonnin @BoD
Update libraries/apollo-api/src/commonMain/kotlin/com/apollographql/a…
2fe76c3 
…pollo3/api/Adapters.kt

Co-authored-by: Benoit Lubek <BoD@JRAF.org>
@martinbonnin @BoD
Update libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/a…
402d4d7 
…pollo3/ast/gqldirective.kt

Co-authored-by: Benoit Lubek <BoD@JRAF.org>
@martinbonnin @BoD
Update libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/a…
1a1ffe3 
…pollo3/ast/internal/definitions.kt

Co-authored-by: Benoit Lubek <BoD@JRAF.org>
@martinbonnin
nooe -> semanticNonNull
e3d6fae
@martinbonnin
fix bad copy paste
e92a2a6
@martinbonnin
update apiDump
da4a0ad
@martinbonnin
hide some more symbol
a5f4d74
@martinbonnin
allow to catch non-ApolloGraphQLException
adf97ff
@martinbonnin
comment + reorder code
5f803f2
@martinbonnin
valueOrNull -> getOrNull for consistency
01fb5e5
@martinbonnin
API visibility
3d5e6cf
@martinbonnin
simplify code and does not generate errorAware() adapter wrappers for…
a28b606 
… non-null types
@martinbonnin
add an quick test
c0f5048
@martinbonnin
fix tests
f69d3c5
@martinbonnin martinbonnin merged commit d14bcb6 into main Dec 1, 2023
@martinbonnin martinbonnin deleted the add-nullability branch December 1, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoD BoD BoD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinbonnin @BoD