Fix WebhookClient.CreateAsync array response handling#45
Merged
Conversation
barnon-apiiro
force-pushed
the
barnon/fix-webhook-create-array-response
branch
from
March 9, 2026 14:19
8df86d3 to
82a9c73
Compare
GitLab API now returns a JSON array from POST /projects/:id/hooks instead of a single object, causing JsonSerializationException. Deserialize as JToken and handle both array and object responses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
barnon-apiiro
force-pushed
the
barnon/fix-webhook-create-array-response
branch
from
March 10, 2026 09:25
82a9c73 to
fee9c90
Compare
daniel-apiiro
approved these changes
Mar 10, 2026
| /// <returns>newly created hook</returns> | ||
| public async Task<Webhook> CreateAsync(ProjectId projectId, CreateWebhookRequest request) => | ||
| await _httpFacade.Post<Webhook>($"projects/{projectId}/hooks", request); | ||
| public async Task<Webhook> CreateAsync(ProjectId projectId, CreateWebhookRequest request) |
There was a problem hiding this comment.
why doesnt it force you to use Task<Webhook?>
Author
There was a problem hiding this comment.
Becuase I relaxed the rules in this repo.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /projects/:id/hooksinstead of a single objectJsonSerializationExceptioninWebhookClient.CreateAsyncwhich expects a singleWebhookJTokenfirst, then handles both array and single object responsesNote: CI fixes are in a separate PR: #46
Test plan
🤖 Generated with Claude Code