docs: Superset 6.1 documentation catch-up — batch 3#39445
docs: Superset 6.1 documentation catch-up — batch 3#39445michael-s-molina merged 2 commits intomasterfrom
Conversation
- development-setup.md: update Node.js prerequisite from v20 to v22 LTS (PR #37223 — project minimum Node version upgraded) - importing-exporting-datasources.mdx: document that masked_encrypted_extra (sensitive connection parameters like service account JSON) is now included in database import/export (PR #38078) - security.mdx: add note that get_samples() enforces datasource-level access control, closing prior gap where unprivileged users could fetch sample rows (PR #36550) - exploring-data.mdx: document natural language time range expressions including new "first of" expressions (first day/week of month/quarter/year) supported in the Custom time range picker (PR #37098) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #0f4a92
Actionable Suggestions - 1
-
docs/docs/using-superset/exploring-data.mdx - 1
- Documentation inaccuracy · Line 334-334
Review Details
-
Files reviewed - 3 · Commit Range:
4cf8f82..4cf8f82- docs/admin_docs/configuration/importing-exporting-datasources.mdx
- docs/admin_docs/security/security.mdx
- docs/docs/using-superset/exploring-data.mdx
-
Files skipped - 1
- docs/developer_docs/contributing/development-setup.md - Reason: Filter setting
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
|
|
||
| ### Time Range Natural Language Expressions | ||
|
|
||
| The **Custom** time range picker accepts natural language expressions alongside specific dates. Superset supports a range of expressions including: |
There was a problem hiding this comment.
The documentation refers to the 'Custom' time range picker, but natural language expressions are actually supported in the 'Advanced' time range picker, which provides text inputs for 'since' and 'until' fields. The 'Custom' picker uses UI controls for building ranges. Please update the title and description to say 'Advanced' instead of 'Custom'.
Code Review Run #0f4a92
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
There was a problem hiding this comment.
Good catch — natural language expressions like Last 7 days and 30 days ago go in the Advanced picker (text inputs for since/until), not Custom (DatePicker/Radio/Select UI controls). This PR is already merged so I'll send the rename through in a follow-up PR to master.
dosubot
Bot
added
doc:developer
Co-authored-by: Superset Dev <dev@superset.apache.org> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit b4f5959)
|
Bito Automatic Review Skipped – PR Already Merged |
Co-authored-by: Superset Dev <dev@superset.apache.org> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2 participants
SUMMARY
Third batch of documentation updates for features merged after 6.0. Continues from #39440 and #39441.
Node.js v22 prerequisite (
development-setup.md) — updates the frontend development prerequisite from Node.js v20 to v22 LTS (PR feat!: upgrade project's Node version to v22 #37223).masked_encrypted_extrain import/export (importing-exporting-datasources.mdx) — documents that sensitive connection parameters stored inmasked_encrypted_extra(service account JSON, OAuth tokens, encrypted credentials) are now included when exporting and importing database connections (PR feat: support for import/export masked_encrypted_extra (frontend) #38078). Includes a note aboutSECRET_KEYrequirements on the receiving instance.get_samples()access control (security.mdx) — adds a note in the SQL Execution Security section that the sample data endpoint now enforces datasource-level permissions, closing a prior gap where under-privileged users could fetch sample rows (PR fix(security): enforce datasource access control in get_samples() #36550).Natural language time range expressions (
exploring-data.mdx) — documents the range of natural language expressions supported in the Custom time range picker, including the new "first of" expressions (first day of this week,first day of this month,first week of this year, etc.) added in PR feat(dates): adding handling for first of #37098.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — documentation-only changes.
TESTING INSTRUCTIONS
cd docs && npm startto verify MDX renders correctlyADDITIONAL INFORMATION
Note: database engine pages (
docs/docs/databases/) are auto-generated at build time and gitignored — Athena dynamic schema (#36003) and StarRocks catalog (#37026) updates require changes to the Python engine specs rather than the MDX files.Fourth PR in the 6.1 docs series (alongside #39422, #39440, #39441).