[SPARK-56018][INFRA][FOLLOW-UP] Install black for older branches in Python CodeGen check#55407
Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56018][INFRA][FOLLOW-UP] Install black for older branches in Python CodeGen check#55407LuciferYang wants to merge 1 commit intoapache:masterfrom
LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
…en check SPARK-56018 replaced `black` with `ruff` in the Python CodeGen check step, but older branches (branch-3.5, branch-4.0, branch-4.1) still use `black` in their `gen-protos.sh`. This causes scheduled builds for those branches to fail with `black: command not found`. This patch adds a conditional step to install `black` for older branches while keeping `ruff` for master and newer branches.
HyukjinKwon
approved these changes
Apr 19, 2026
dongjoon-hyun
approved these changes
Apr 20, 2026
Contributor
Author
|
Merged into master.Thanks @dongjoon-hyun and @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a conditional step in the
bufjob ofbuild_and_test.ymlto installblackfor older branches while keepingruffformasterand newer branches.Why are the changes needed?
SPARK-56018 replaced
blackwithruffas the Python formatter in the "Install dependencies for Python CodeGen check" step. However, this workflow is also used by scheduled builds for older branches, whosegen-protos.shstill callsblackfor formatting. This causes those builds to fail with:For example: https://github.com/apache/spark/actions/runs/24597946594/job/71931532850
Does this PR introduce any user-facing change?
No
How was this patch tested?
Monitor the daily test results for branch-4.1 after merging.
Was this patch authored or co-authored using generative AI tooling?
No