Skip to content

GH-506: Clarify field ordering for partially shredded object union #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nssalian wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −0
Open

GH-506: Clarify field ordering for partially shredded object union #565

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
602a7db
Update spec to clarify union of shredded objects ordering
nssalian Apr 15, 2026
cef74e1
Add exact language to help clear it up
nssalian Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions VariantShredding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,9 @@ def construct_variant(metadata: Metadata, value: Variant, typed_value: Any) -> V
assert typed_value.keys().isdisjoint(value.keys()), "object keys must be disjoint"

# union the shredded fields and non-shredded fields
# (field IDs and offsets must be in the order of the
# corresponding field names, sorted lexicographically
# (unsigned byte ordering for UTF-8))
return VariantObject(metadata, object_fields).union(VariantObject(metadata, value))

else:
Expand Down