HDDS-14996. Add metrics to track Snapshot backup SST file stats.#10065
Draft
jojochuang wants to merge 4 commits intoapache:masterfrom
Draft
HDDS-14996. Add metrics to track Snapshot backup SST file stats.#10065jojochuang wants to merge 4 commits intoapache:masterfrom
jojochuang wants to merge 4 commits intoapache:masterfrom
Conversation
Change-Id: Ib531e9a99d2e98a2e7b2a8ec4e39a3c36cd9aaa0
Change-Id: I0c50b044a6d44ea9d4eb0f96e4202d76998c9b41
…Metrics. Change-Id: I162534c354312e0c33ee7fc4cabb646ac48780c8
sadanand48
reviewed
Apr 10, 2026
| assertEquals(2, metrics.getNumSnapshots()); | ||
| // Total SST count should still be 1 if hardlink is counted once, | ||
| // but the implementation uses visitedInodes per snapshot directory? | ||
| // Wait, let's check the implementation again. |
Contributor
There was a problem hiding this comment.
yes this is fixed now with a global hashset instead of at per snapshot dir. Thanks for the fixing. The comments may not be needed
| @@ -132,54 +152,93 @@ protected boolean updateMetrics() { | |||
| * | |||
| * @param directory the directory containing all checkpointDirs. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * @param directory the directory containing all checkpointDirs. | |
| * @param snapshotsDir the directory containing all checkpointDirs. | |
| * @param sstBackupDir the backup SST directory |
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OMSnapshotDirectoryMetrics.java
Outdated
Show resolved
Hide resolved
Change-Id: I5b70076aa2549f9c2839acf873b8e316c1e85325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-14996. Add metrics to track Snapshot backup SST file stats.
Please describe your PR in detail:
directory.
inode-based deduplication for hard-linked files.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14996
How was this patch tested?
New unit tests