Fix #12080: mvnup - comment out dependencies with undefined property expressions#12083
Merged
Merged
Conversation
This was referenced May 18, 2026
gnodet
force-pushed
the
fix-12080-comment-undefined-property-deps
branch
4 times, most recently
from
May 26, 2026 14:09
784626d to
6878cea
Compare
Move Maven session management (getSession, createMaven4Session, TransporterFactoryConfig, temp directory helpers, buildEffectiveModel) from PluginUpgradeStrategy into AbstractUpgradeStrategy to enable reuse across strategies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…expressions Comment out dependencies whose version uses a property expression that is not defined in any POM in the reactor. Scans <properties> sections including those in profiles. Well-known properties (project.*, env.*, maven.*, etc.) are excluded from the check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
fix-12080-comment-undefined-property-deps
branch
from
May 26, 2026 14:11
6878cea to
da17364
Compare
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompatibilityFixStrategythat comments out dependencies with undefined property expressions in their coordinates (groupId, artifactId, version)<properties>sections across the reactor (including profiles), skips well-known built-ins (project.*,env.*,settings.*,maven.*,revision,sha1,changelist, etc.)Editor.commentOutElement()with a<!-- mvnup: commented out - undefined property '...' -->marker for easy identification and reversalFixes #12080
Test plan
${project.version}) is preservedCompatibilityFixStrategyTesttests pass🤖 Generated with Claude Code
Claude Code on behalf of Guillaume Nodet