Fix Windows flake in CommandChannelDecoderTest (#3400) Backport of #3400 in surefire-3.5.x branch - #3403
Open
olamy wants to merge 1 commit into
Open
Fix Windows flake in CommandChannelDecoderTest (#3400) Backport of #3400 in surefire-3.5.x branch#3403olamy wants to merge 1 commit into
olamy wants to merge 1 commit into
Conversation
Backport of apache#3400 in surefire-3.5.x branch The test initializes DumpErrorSingleton into the JUnit @tempdir; several tests write .dumpstream files there. On Windows a freshly written file can be transiently locked (antivirus, indexer) right when the @tempdir cleanup runs, failing the whole class with DirectoryNotEmptyException ('Failed to close extension context'). JUnit 5.14's resilient cleanup retries do not close the gap. Writing the dumps under target/ needs no post-test cleanup at all. Co-authored-by: Gerd Aschemann <ascheman@apache.org> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test initializes DumpErrorSingleton into the JUnit @tempdir;
several tests write .dumpstream files there. On Windows a freshly
written file can be transiently locked (antivirus, indexer) right when
the @tempdir cleanup runs, failing the whole class with
DirectoryNotEmptyException ('Failed to close extension context').
JUnit 5.14's resilient cleanup retries do not close the gap. Writing
the dumps under target/ needs no post-test cleanup at all.
Co-authored-by: Gerd Aschemann ascheman@apache.org
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.