Skip to content

Namespace is http://maven.apache.org/POM/4.0.0 #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

Namespace is http://maven.apache.org/POM/4.0.0 #799

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7b93ea
Namespace is http://maven.apache.org/POM/4.0.0
elharo Mar 20, 2026
bdfde01
concatenate
elharo Mar 20, 2026
f75cc30
Merge branch 'master' into fix
elharo Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/apache/maven/plugins/shade/pom/PomWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static void write(Writer w, Model newModel, boolean namespaceDeclaration)
if (namespaceDeclaration) {
String modelVersion = newModel.getModelVersion();

Namespace pomNamespace = Namespace.getNamespace("", "http://maven.apache.org/POM/" + modelVersion);
Namespace pomNamespace = Namespace.getNamespace("http://maven.apache.org/POM/4.0.0");

Comment thread
elharo marked this conversation as resolved.
root.setNamespace(pomNamespace);

Expand All @@ -52,7 +52,7 @@ public static void write(Writer w, Model newModel, boolean namespaceDeclaration)
if (root.getAttribute("schemaLocation", xsiNamespace) == null) {
root.setAttribute(
"schemaLocation",
"http://maven.apache.org/POM/" + modelVersion + " http://maven.apache.org/maven-v"
"http://maven.apache.org/POM/4.0.0" + " http://maven.apache.org/maven-v"

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concatenation joins two string literals (".../4.0.0" + " http://...") which is harder to read than a single literal. Collapsing it into one string (or building it from constants) would improve readability.

Suggested change
"http://maven.apache.org/POM/4.0.0" + " http://maven.apache.org/maven-v"
"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v"

Copilot uses AI. Check for mistakes.
+ modelVersion.replace('.', '_') + ".xsd",
xsiNamespace);
}
Expand Down
Loading