Skip to content

Custom GradleWrapper #16483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dsmiley wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Custom GradleWrapper #16483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
368b095
Custom GradleWrapper
dsmiley Aug 4, 2026
4597b37
Compile the source first.
dsmiley Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/actions/prepare-for-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,6 @@ runs:
java-version: ${{ inputs.java-version }}
java-package: jdk

- name: Cache gradle-wrapper.jar
if: ${{ fromJSON(inputs.use-cache) }}
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: gradle/wrapper/gradle-wrapper.jar
key: gradle-wrapper-${{ hashFiles('gradle/wrapper/gradle-wrapper.jar.sha256') }}

# This includes "smart" caching of gradle dependencies.
- name: Set up Gradle
if: ${{ fromJSON(inputs.use-cache) }}
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
.gradle/
build/

# Ignore gradle wrapper jar.
gradle/wrapper/gradle-wrapper.jar

Comment on lines -8 to -10

@dweiss dweiss Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed from gitignore yet the batch scripts clearly seem to support the presence of gradle wrapper (?). I also wonder how IDEs are going to react to the missing wrapper file...

# IntelliJ IDEA
**/.idea/*
# Do add the icon to git
Expand Down
264 changes: 0 additions & 264 deletions build-tools/build-infra/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java
View file
Open in desktop

This file was deleted.

Loading
Loading