CI: Make CVE scan blocking on PRs, informational on main#16287
CI: Make CVE scan blocking on PRs, informational on main#16287kevinjqliu wants to merge 8 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
The idea of running on PR is in case the PR were to introduce a CVE. |
what about information only for main branch but blocking on PR? |
| - '2.*' | ||
| tags: | ||
| - 'apache-iceberg-**' | ||
| pull_request: |
There was a problem hiding this comment.
I think we need to fail on PR and be informational on main. I actually found my way to this PR because the post-merge scan on #16279 failed, and I'd rather have seen those CVEs at review time than after they landed on main.
|
made the change to block for PR. |
|
one consideration is that there is a "unfixable" CVE in main (see #16290) Known unfixable
I think we could add this to a |
+1 |
f6f14d1 to
99162bd
Compare
Co-authored-by: Copilot <copilot@github.com>
9017725 to
72a4ea1
Compare
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Follow up to #15430 and #16291.
This make the CVE scan blocking on PRs but only information on main (CVEs will be sent to the Github "security" tab)
Note that all (except 1) CVEs found was fix forward in #16290
The 1 leftover CVE is for Spark 3.4. Adding it to the trivy ignore list for now since we'll be removing Spark 3.4 very soon (#14122)
We should not use trivy ignore list in general, this is an exception.