Skip to content

review comments #2

509b95a
Select commit
Loading
Failed to load commit list.
Merged

HIVE-25948: Iceberg: Enable cost-based selection between Fanout and Clustered writers using column stats NDV #6389

review comments #2
509b95a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 8, 2026 in 17m 59s

Annotations

Check warning on line 881 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 8, expected level should be 6.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gt2&open=AZ0i1xVfDAKfaaDB0gt2&pullRequest=6389

Check warning on line 878 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gtz&open=AZ0i1xVfDAKfaaDB0gtz&pullRequest=6389

Check warning on line 883 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gt4&open=AZ0i1xVfDAKfaaDB0gt4&pullRequest=6389

Check warning on line 880 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gt1&open=AZ0i1xVfDAKfaaDB0gt1&pullRequest=6389

Check warning on line 882 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gt3&open=AZ0i1xVfDAKfaaDB0gt3&pullRequest=6389

Check warning on line 876 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gtx&open=AZ0i1xVfDAKfaaDB0gtx&pullRequest=6389

Check warning on line 875 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 8, expected level should be 6.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gtw&open=AZ0i1xVfDAKfaaDB0gtw&pullRequest=6389

Check warning on line 877 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 8, expected level should be 6.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gty&open=AZ0i1xVfDAKfaaDB0gty&pullRequest=6389

Check warning on line 879 in ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 8, expected level should be 6.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ0i1xVfDAKfaaDB0gt0&open=AZ0i1xVfDAKfaaDB0gt0&pullRequest=6389

Check warning on line 35 in iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/udf/TestGenericUDFIcebergBucketStatEstimator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one.

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ1kBKSI0jMYmy4UasF7&open=AZ1kBKSI0jMYmy4UasF7&pullRequest=6389