Skip to content

HIVE-29287: Iceberg: [V3] Variant Shredding support #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deniskuzZ merged 3 commits into from
Dec 12, 2025

sonar + test + refeactor

f17b676
Select commit
Loading
Failed to load commit list.
Merged

HIVE-29287: Iceberg: [V3] Variant Shredding support #6152

sonar + test + refeactor
f17b676
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 5, 2025 in 23m 6s

Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 145 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof EncryptedOutputFile encryptedoutputfile' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r24&open=AZru_m9FJB0kz5OX_r24&pullRequest=6152

Check warning on line 1235 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3G&open=AZru_m9FJB0kz5OX_r3G&pullRequest=6152

Check failure on line 393 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r22&open=AZru_m9FJB0kz5OX_r22&pullRequest=6152

Check warning on line 1322 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3J&open=AZru_m9FJB0kz5OX_r3J&pullRequest=6152

Check warning on line 184 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveFileWriterFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m4pJB0kz5OX_r2z&open=AZru_m4pJB0kz5OX_r2z&pullRequest=6152

Check warning on line 1294 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof HadoopInputFile hadoopinputfile' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3I&open=AZru_m9FJB0kz5OX_r3I&pullRequest=6152

Check warning on line 1036 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the type specification in this constructor call with the diamond operator ("<>"). 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r21&open=AZru_m9FJB0kz5OX_r21&pullRequest=6152

Check warning on line 1109 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof NativeEncryptionInputFile nativeFile' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3C&open=AZru_m9FJB0kz5OX_r3C&pullRequest=6152

Check warning on line 129 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r23&open=AZru_m9FJB0kz5OX_r23&pullRequest=6152

Check warning on line 457 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "withRowGroupSize"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r29&open=AZru_m9FJB0kz5OX_r29&pullRequest=6152

Check warning on line 1475 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ParquetFileWriter"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3L&open=AZru_m9FJB0kz5OX_r3L&pullRequest=6152

Check failure on line 1278 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 37 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3H&open=AZru_m9FJB0kz5OX_r3H&pullRequest=6152

Check warning on line 249 in iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergSelects.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "path"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9hJB0kz5OX_r3O&open=AZru_m9hJB0kz5OX_r3O&pullRequest=6152

Check warning on line 1234 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add 'since' and/or 'forRemoval' arguments to the @Deprecated annotation. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3F&open=AZru_m9FJB0kz5OX_r3F&pullRequest=6152

Check warning on line 1502 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof Variant variant' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3M&open=AZru_m9FJB0kz5OX_r3M&pullRequest=6152

Check warning on line 1185 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add 'since' and/or 'forRemoval' arguments to the @Deprecated annotation. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3D&open=AZru_m9FJB0kz5OX_r3D&pullRequest=6152

Check warning on line 722 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof NativeEncryptionOutputFile nativeFile' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3A&open=AZru_m9FJB0kz5OX_r3A&pullRequest=6152

Check warning on line 1278 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 117 to 64, Complexity from 21 to 14, Nesting Level from 3 to 2, Number of Variables from 17 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3N&open=AZru_m9FJB0kz5OX_r3N&pullRequest=6152

Check warning on line 1186 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3E&open=AZru_m9FJB0kz5OX_r3E&pullRequest=6152

Check warning on line 319 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to use the more specialised Functional Interface 'ObjDoubleConsumer<String>' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r28&open=AZru_m9FJB0kz5OX_r28&pullRequest=6152

Check warning on line 303 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "writerVersion" on line 272. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r26&open=AZru_m9FJB0kz5OX_r26&pullRequest=6152

Check warning on line 851 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof NativeEncryptionOutputFile nativeFile' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r3B&open=AZru_m9FJB0kz5OX_r3B&pullRequest=6152

Check warning on line 1322 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r20&open=AZru_m9FJB0kz5OX_r20&pullRequest=6152

Check warning on line 470 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ParquetWriteAdapter"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r2-&open=AZru_m9FJB0kz5OX_r2-&pullRequest=6152

Check warning on line 182 in iceberg/iceberg-handler/src/main/java/org/apache/iceberg/parquet/Parquet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof HadoopOutputFile hadoopoutputfile' 

See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZru_m9FJB0kz5OX_r27&open=AZru_m9FJB0kz5OX_r27&pullRequest=6152
View more details on SonarQubeCloud