-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[feat]:add db account monitoring metrics for postgresql. #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wy471x
wants to merge
8
commits into
apache:master
Choose a base branch
from
wy471x:feat_db-account_monitoring_metrics-#3737
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−6
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
379d950
[feat]:add db account monitoring metrics for postgresql.
wy471x 5ce1b04
Merge branch 'master' into feat_db-account_monitoring_metrics-#3737
wy471x b4eaa0d
Merge branch 'master' into feat_db-account_monitoring_metrics-#3737
Duansg 63994ff
[feat]:add db account monitoring metrics for postgresql.
wy471x 8ee6ee0
Merge branch 'master' into feat_db-account_monitoring_metrics-#3737
Duansg e9e0f79
Merge branch 'master' into feat_db-account_monitoring_metrics-#3737
wy471x 8204af4
[feat]:switch querying account info from table pg_user to pg_roles.
wy471x c7b608e
Merge branch 'master' into feat_db-account_monitoring_metrics-#3737
wy471x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting with version 8.1, PostgreSQL adopted the
rolesmodel. I see that the olduserscompatibility view is being used here. Should we consider switching toroles?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I also agree with your opinion. I have made modifications to this. Please take a look when you have time. Thank you.